beyonddream/hamurabi

Hamurabi text based strategy game ported to C.

hamurabi's Issues

use base path syntax for includes

Currently include syntax uses relative path, "../include/hamurabi.h" in hamurabi.c
This change would convert them into base path relative.

fix issues around random number generator

1. random number generator is broken
2. remove macro and use function to make the code more straightforward and testable
3. add tests

Add docker support to build and run on Linux

remove dynamic alloc of city struct

dynamic alloc is not needed in this case and can be replaced with data on the stack

sanitize input and out of scanf when receiving user input

This is a good practice to do anyways no matter this small game.

add compiler sanitize flags while building to catch static/dynamic errors

Remove gpl'ed code from the repo

There is one file that is cribbed from git (header file to cause compilation error if unsafe c functions are called) which made the entire repo to be GPL'ed. I wanted to release this repo under less restrictive license like MIT or Apache 2, so remove the gpl'ed code so I can do that.

remove unnecessary type cast of numbers

remove the use of goto's

SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/hamurabi.c:395:23

There is an UB when built using

cc -Wall -Wextra -Og -g -fsanitize=address,undefined src/*.c

add cmake config to generate C compilation db (clang) to assist vim ale to find headers properly

fix cmake errors on Check on fresh build

from F54280 on r/C_programming - the default build scripts on my OSX machine gives:

-- Found PkgConfig: /usr/local/bin/pkg-config (found version "0.29.2")
CMake Error at cmake/FindCheck.cmake:43 (MESSAGE):
Could NOT find CHECK
Call Stack (most recent call first):
CMakeLists.txt:33 (find_package)