Giter Site home page Giter Site logo

Comments (7)

MikeEdgar avatar MikeEdgar commented on July 30, 2024

I think this one is effectively supported now that the parameter customization script is available from #163

from kas-installer.

machi1990 avatar machi1990 commented on July 30, 2024

Good thinking.
At the moment we are overriding the cluster list and supported cloud providers here: https://github.com/MikeEdgar/kas-installer/blob/542f3f8d443fe4273d8f89ced38e4dcd824744c1/kas-fleet-manager/deploy-kas-fleet-manager.sh#L172-L194

And the parameter customization comes before those two at https://github.com/MikeEdgar/kas-installer/blob/542f3f8d443fe4273d8f89ced38e4dcd824744c1/kas-fleet-manager/deploy-kas-fleet-manager.sh#L159

I wonder if oc is clever enough to merge everything. If so and everything works as advertised, then this will be something we might look to add documentation for as well. If not, we might look to tweak things a bit to add multi cloud provider / region support.

from kas-installer.

MikeEdgar avatar MikeEdgar commented on July 30, 2024

Yeah, thinking about it a bit more, maybe it would be better to pass SUPPORTED_CLOUD_PROVIDERS the same way that KAS_FLEETSHARD_OPERATOR_SUBSCRIPTION_CONFIG is passed. That is, only if the user hasn't given their own value via the custom script. The challenge will be aligning with CLUSTER_LIST which isn't trivial to just allow to be configured via the custom script.

from kas-installer.

machi1990 avatar machi1990 commented on July 30, 2024

Yeah, thinking about it a bit more, maybe it would be better to pass SUPPORTED_CLOUD_PROVIDERS the same way that KAS_FLEETSHARD_OPERATOR_SUBSCRIPTION_CONFIG is passed.

+1 Exactly my thinking.

The challenge will be aligning with CLUSTER_LIST which isn't trivial to just allow to be configured via the custom script.

Why will this be challenging?

from kas-installer.

MikeEdgar avatar MikeEdgar commented on July 30, 2024

The challenge will be aligning with CLUSTER_LIST which isn't trivial to just allow to be configured via the custom script.

Why will this be challenging?

I'm mainly thinking about the name being currently aligned with the KUBE_CONFIG in the secrets and the PROVIDER_TYPE logic a bit earlier in the script. Allowing the CLUSTER_LIST to be set directly would require either those to be configurable or to just accept that users have a good knowledge around the requirements of forming a correct CLUSTER_LIST within the context of the rest of the script.

from kas-installer.

MikeEdgar avatar MikeEdgar commented on July 30, 2024

Regarding both "multi cloud" and "multi region" is the requirement to support both simultaneously? That is, there would be multiple clusters, different cloud providers and different regions?

from kas-installer.

machi1990 avatar machi1990 commented on July 30, 2024

The challenge will be aligning with CLUSTER_LIST which isn't trivial to just allow to be configured via the custom script.

Why will this be challenging?

I'm mainly thinking about the name being currently aligned with the KUBE_CONFIG in the secrets and the PROVIDER_TYPE logic a bit earlier in the script. Allowing the CLUSTER_LIST to be set directly would require either those to be configurable or to just accept that users have a good knowledge around the requirements of forming a correct CLUSTER_LIST within the context of the rest of the script.

You are right. Any standalone configured cluster must have the name in the provided kubeconfig. So as long as the users pass in the correct kubeconfig with all the standalone clusters, and we have it documented on how they can set their CLUSTER_LIST, it will be problem solved as I do not think we can automate it further for them. If the CLUSTER_LIST is not set, then we default to setting it automatically like what is being done now.

Regarding both "multi cloud" and "multi region" is the requirement to support both simultaneously? That is, there would be multiple clusters, different cloud providers and different regions?

The control plane allows for the configuration of both. So if we can allow the customization of both cloud provider and region at the same time, that's perfect. One can as well pass a list of cloud providers and their corresponding region and they both will be supported.
So if we allow to pass in multiple cloud providers and regions and those are enabled, one has to also have the option to configure the clusters via CLUSTER_LIST and this is where the two are connected. If we pass only one cluster which is specific to a region and a cloud provider, the rest of the cloud provider and regions will only be there (shown in the /api/kafkas_mgmt/v1/cloud_providers endpoint as enabled) but one cannot provision a Kafka onto them.

from kas-installer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.