Giter Site home page Giter Site logo

Comments (18)

machi1990 avatar machi1990 commented on July 30, 2024 1

@MikeEdgar

from kas-installer.

dimakis avatar dimakis commented on July 30, 2024 1

Are you thinking a wrapper/convenience script or guidance to use rhoas?

+1 .I know for a fact that this is a planned work in the CLI, @dimakis can you confirm? So, I think kas-installer needs to only do it after the CLI has support for it. In the meanwhile, the user can directly call the KFM endpoint. What do you think?

indeed, we do plan on adding a de-register command to the CLI 👍

from kas-installer.

MikeEdgar avatar MikeEdgar commented on July 30, 2024 1

So, I think kas-installer needs to only do it after the CLI has support for it. In the meanwhile, the user can directly call the KFM endpoint. What do you think?

I don't mind scripting it in the short term. At a minimum, it will give me some hands-on experience with the new endpoint(s) and would be good to have in the uninstall.sh process too. It might be good to have a version de-registration available outside of rhoas anyway for the un-installation to avoid relying on an active session, etc.

from kas-installer.

machi1990 avatar machi1990 commented on July 30, 2024 1

I don't mind scripting it in the short term. At a minimum, it will give me some hands-on experience with the new endpoint(s) and would be good to have in the uninstall.sh process too. It might be good to have a version de-registration available outside of rhoas anyway for the un-installation to avoid relying on an active session, etc.

Okay. One thing the script will need to do as well is - remove the AddOns.

from kas-installer.

MikeEdgar avatar MikeEdgar commented on July 30, 2024 1

Is it expected that the bootstrap domain does not have the kas prefix when CNAME registration is not used? I see in rhoas that the apps subdomain is removed from the cluster DNS, which means KFM does not replace it with kas.

from kas-installer.

machi1990 avatar machi1990 commented on July 30, 2024 1

@MikeEdgar @dimakis here is an attempt for a fix redhat-developer/app-services-cli#1806 please have a look.

from kas-installer.

MikeEdgar avatar MikeEdgar commented on July 30, 2024

make sure that KFM is running in OCM mode and not standalone mode when enterprise feature is to be used

Do you envision a new flag that indicates whether the user intends to use enterprise features and the installer performs some basic validation and generates an empty CLUSTER_LIST based on that?

Update SUPPORTED_INSTANCE_TYPES: https://github.com/bf2fc6cc711aee1a0c2a/kas-fleet-manager/blob/main/templates/service-template.yml#L160 for include supported billing models

kas-installer currently just uses the default from the template unless the user intentionally overrides this via a kas-fleet-manager-service-template-params script. With the tag update, the default value includes all of the billing types so we may be covered on this out-of-the-box. Thoughts?

Being able to deregister an enterprise cluster

Are you thinking a wrapper/convenience script or guidance to use rhoas?

from kas-installer.

machi1990 avatar machi1990 commented on July 30, 2024

make sure that KFM is running in OCM mode and not standalone mode when enterprise feature is to be used

Do you envision a new flag that indicates whether the user intends to use enterprise features and the installer performs some basic validation and generates an empty CLUSTER_LIST based on that?

I was thinking this as well. What do you think?

Update SUPPORTED_INSTANCE_TYPES: https://github.com/bf2fc6cc711aee1a0c2a/kas-fleet-manager/blob/main/templates/service-template.yml#L160 for include supported billing models

kas-installer currently just uses the default from the template unless the user intentionally overrides this via a kas-fleet-manager-service-template-params script. With the tag update, the default value includes all of the billing types so we may be covered on this out-of-the-box. Thoughts?

+1. So is a quick win. I hope no one overrides the default one in their kas-fleet-manager-service-template-params script.

Being able to deregister an enterprise cluster

Are you thinking a wrapper/convenience script or guidance to use rhoas?

+1 .I know for a fact that this is a planned work in the CLI, @dimakis can you confirm? So, I think kas-installer needs to only do it after the CLI has support for it. In the meanwhile, the user can directly call the KFM endpoint. What do you think?

from kas-installer.

MikeEdgar avatar MikeEdgar commented on July 30, 2024

Being able to register the cluster with KFM. We can use the latest release of the rhoas CLI for this.

Based on my understanding of the CLI on the dedicated branch, we may be blocked on this until a separate OCM API endpoint can be specified.

from kas-installer.

machi1990 avatar machi1990 commented on July 30, 2024

Being able to register the cluster with KFM. We can use the latest release of the rhoas CLI for this.

Based on my understanding of the CLI on the dedicated branch, we may be blocked on this until a separate OCM API endpoint can be specified.

@dimakis created an alpha release a few weeks ago. Maybe we can have another one with latest changes on redhat-developer/app-services-cli#1804. Any plans on that @dimakis ?

from kas-installer.

dimakis avatar dimakis commented on July 30, 2024

Being able to register the cluster with KFM. We can use the latest release of the rhoas CLI for this.

Based on my understanding of the CLI on the dedicated branch, we may be blocked on this until a separate OCM API endpoint can be specified.

@dimakis created an alpha release a few weeks ago. Maybe we can have another one with latest changes on redhat-developer/app-services-cli#1804. Any plans on that @dimakis ?

I'm just waiting for someone to approve those changes. As soon as I do I'll release another alpha with the latest changes.

from kas-installer.

MikeEdgar avatar MikeEdgar commented on July 30, 2024

Very nice, I didn't see that PR. I'll at least try to run that locally until there is a release with those changes. Thanks for mentioning it @machi1990 !

from kas-installer.

dimakis avatar dimakis commented on July 30, 2024

Very nice, I didn't see that PR. I'll at least try to run that locally until there is a release with those changes. Thanks for mentioning it @machi1990 !

there's an alpha release now with the most up to date changes:

curl -o- https://raw.githubusercontent.com/redhat-developer/app-services-cli/main/scripts/install.sh | bash -s v0.52.2-alpha1

will grap and install it 👍

from kas-installer.

machi1990 avatar machi1990 commented on July 30, 2024

Is it expected that the bootstrap domain does not have the kas prefix when CNAME registration is not used? I see in rhoas that the apps subdomain is removed from the cluster DNS, which means KFM does not replace it with kas.

Good catch, that's a bug. apps. should be there for the cluster_dns when CNAME registration is not used. /cc @dimakis

from kas-installer.

machi1990 avatar machi1990 commented on July 30, 2024

@MikeEdgar @dimakis I'll prepare a PR against RHOAS CLI and ping you on it.

from kas-installer.

dimakis avatar dimakis commented on July 30, 2024

Is it expected that the bootstrap domain does not have the kas prefix when CNAME registration is not used? I see in rhoas that the apps subdomain is removed from the cluster DNS, which means KFM does not replace it with kas.

Good catch, that's a bug. apps. should be there for the cluster_dns when CNAME registration is not used. /cc @dimakis

So are there instances of the DNS where the ".apps." Is not in the DNS?

from kas-installer.

MikeEdgar avatar MikeEdgar commented on July 30, 2024

So are there instances of the DNS where the ".apps." Is not in the DNS?

The default ingress for OSD handles the apps subdomain, but for MK there are additional subdomains created where apps is replaced with kas. The current KFM logic just swaps the subdomain (search/replace) so it's expected to be there in the cluster configuration.

from kas-installer.

machi1990 avatar machi1990 commented on July 30, 2024

Thanks @MikeEdgar

all the tasks in this are completed. I’ll close the issue

from kas-installer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.