Giter Site home page Giter Site logo

Comments (4)

franciscave avatar franciscave commented on September 27, 2024

The element R16D01 and R16C02 (R16D02 is an error in the spec) are intended to be mutually exclusive. Either the response contains a reference to the reservation or it contains the reservation entity. If there are charges associated with the reservation and the reservation entity itself is not returned in the response, references to any associated charges should be included in the response, to alert the user to the charges, which they might otherwise miss if they don't choose to retrieve the full reservation entity.

I think there was a business case for not returning the full reservation entity, but I confess that I no longer remember what it was. It may be that we can drop from the REST Web Server the option of returning a reservation reference, in which case the optional charge references in the response can also be dropped.

from bic-lcf.

franciscave avatar franciscave commented on September 27, 2024

This was discussed at the Technical Panel meeting on 28 June. After some discussion it was agreed that, for the web service implementation at least, it is only ever necessary to return a reservation reference URI in the reservation response. The documentation and XML schema should therefore be changed to remove the option of including the whole reservation record in the response.

from bic-lcf.

anthonywhitford avatar anthonywhitford commented on September 27, 2024

Having reviewed the comments above, I think @mdovey has a valid point that there is no purpose in the entity "lcf-reservation-response". Returning the reservation entity answers all the questions, and the LMS/ILS should have all the required information since it has just completed creating the reservation.

The one caveat on this statement is what should be returned if the business rules deny the creation of the reservation? The current LCF spec states that the lcf-exception entity should be returned along with the appropriate HTTP response code.

Given these two scenarios of use, I think the existing lcf-reservation-response should be removed.

from bic-lcf.

franciscave avatar franciscave commented on September 27, 2024

I agree. I have edited circulation function 16 in the LCF 1.0.1 REST Web Services Specification to reflect this decision. The specification now says that the only response to a reservation request should be either an HTTP 201 response (if successful) or an LCF Exception Response (if not successful).

from bic-lcf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.