bigbag/starlette-i18n

Localisation helper for starlette

starlette-i18n's Issues

Complex language codes not detected properly

Hi,

In case of complex language codes in Accept-Language header, f.ex. es-419, zh-CN, pt-BR, zh-TW LocaleFromHeaderMiddleware falls back to English even if valid folders with translations are present in locales dir. I was able to fix it here: main...r4fek:starlette-i18n:main#diff-0a2167031d28db7308f3855e50ffd9154a327d22042f80d0ebf67a283fb622be

but you may want to take a closer look into this.
I can prepare a MR if you like.

Downgrade starlette version

Hi @bigbag,
first of all, thank you for this package, I was struggling with this i18n stuff!

I don't know if there is a good reason to set starlette version to the last one, but if it is not the case, can you consider downgrade it to something like starlette>=14.0.0 ? This will make some FastAPI users happy since the latter will always be late to catch up starlette version.

Is starlette-i18n limited to provide only one extra locale?

Do I understand correctly that starlette-i18n cannot provide more than one translation locale at a time? Examples here also deliver only one extra locale besides English as the default language. Is that intentional and expresses a limitation of using starlette-i18n and more generally jinja2.ext.i18n for ASGI frameworks like Starlette?

I found related discussions at encode/starlette#279 (comment) and pallets/jinja#1323 (comment), but maybe you @bigbag as the author of this localisation helper have further comments and maybe some practical suggestions on this?

Example with Jinja2?

Do you have an example of using this with Jinja2 templates? I found this discussion saying to use dictionaries to translate in templates but perhaps there is a better way with your project. encode/starlette#279