bignoid/service.library.data.provider

Python script for use with XBMC

service.library.data.provider's Issues

Recent / random albums onclick function open track listing instead of play album?

AttributeError: 'Widgets_Player' object has no attribute 'mediatype'

The following exception sometimes occur when playing videos that are not in the library:

22:50:18 T:4008   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.AttributeError'>
                                            Error Contents: 'Widgets_Player' object has no attribute 'mediatype'
                                            Traceback (most recent call last):
                                              File "D:\XBMC\portable_data\addons\service.library.data.provider\service.py", line 580, in onPlayBackEnded
                                                self.onPlayBackStopped()
                                              File "D:\XBMC\portable_data\addons\service.library.data.provider\service.py", line 583, in onPlayBackStopped
                                                if self.mediatype == 'movie':
                                            AttributeError: 'Widgets_Player' object has no attribute 'mediatype'
                                            -->End of Python script error report<--

ListItem.Type / ListItem.Property(Type)

Hello,

First I want to thank you for your work on this script. One "issue" I have is the missing ListItem.Type infolabel for dynamic lists.

e.g. one example would be.:
When using the "recentvideos" content list, it would be nice to have different images (Poster or Thumb) based on content (Movie or Episode) but this can only be done if I can distinguish based on ListItem.Type(movie/episode).

There are more situations where this could be really helpful, so for the sake of completeness it would be nice to have this infolabel available.

thanks again!

recentmovies/recentepisodes descending/ascending by date issue

Today I noticed that recentmovies won't update correctly:
I added a few movies to the library and the recentmoves still show old ones (20 items, unwatched). After one of them is watched, a newer one will appear in the list.

I disabled the "only unwatched" option and the issue is still there. Noticed on recentmovies/recentepisodes, can't say if it affects the other recent items, too.

It seems that the recent items are sorted in wrong direction (date descending/ascending issue). The newest one should be in Container.Position(0).

Recommended episodes and movies in same list

Not an issue, but a feature request:

Would it be possible to have this:

<content target="video">plugin://service.library.data.provider?type=recommendedmovies+recommendedepisodes&amp;reload=$INFO[Window.Property(recommendedmovies)]$INFO[Window.Property(recommendedepisodes)]</content>

populate the list in the order they were last played?
At the moment, it loads them in order, like this:

[movie1] [movie2] [movie3] [episode1] [episode2]

Say I played movie 3 for a bit, then episode 2. I would like this list:

[movie3] [episode2] [movie1] [movie2] [episode1]
Playing episode 1, then movie 3 again produces

[movie3] [episode1] [episode2] [movie1] [movie2]

Well, you get the point. :) Look at how the Leanback launcher on Android TV shows recommendations. That's what I'm trying to accomplish.

Limit parameter

At the moment the "limit=" parameter works only if you want to decrease the items number lower then 20. Is it possible to use the limit parameter to increase the number of items to more then 20 ?

Cheers
Nessus

update dependencies

remove xbmc.addon
update xbmc.python to 2.14.0

Duration info not showing in all movies

Duration info not showing in all movies. Is something broken in my library (although duration is showing fine in all other sections) or am i doing something wrong ?

This is the code that i am using:
$INFO[Container(id).ListItem.Year]$INFO[Container(id).ListItem.Rating, • ,]$INFO[Container(id).ListItem.Duration, • , $LOCALIZE[12391]]

EDIT: Just saw this ffce7e5 commit. Is this related to my issue ?

Cheers
Nessus

Just a nit - left over debug?

When this service starts I get the following in the log

04:40:57 10934.314453 T:2748216400  NOTICE: {}

which I eventually tracked down to service.py.

Either this print statement should be changed to log(str(params)), or eliminated entirely as without knowing the source of this log information it's a bit annoying (looks untidy).

feature request: sort recommended episodes on date

Hi,

Just a little feature request for whenever you have time for this:
Is it possible to sort the "recommended episodes" on date ? So, the episode of the last watched TV show first ?

If you want I can take a look myself and send you a MR ?

Regards,

Marcel

Option to limit update frequencies

Looking through the source, it seems to me that the service updates every 10 minutes, when media is not playing.
Would it be possible to limit this to only update when entering the home screen or the library? Or maybe disable updating after X minutes of user inactivity. After all, there's no reason for updating when XBMC is not in use.
With the current implementation, my server wont ever go to sleep, because each service refresh triggers a MySQL query, which in turn wakes the server/prolongs the sleep-timeout.

This service addon needs an icon

=)

visibility in add-on views

Got this question in my skin's forum thread:

On a fresh install of Gotham Beta 3, when I tried to install reFocus, I got the 'dependencies not met' error.

Following the previous post I install the service.library.data.provider plugin, which made reFocus happy.

Problem is, now the Service Library Data Provider plugin appears in both my Video Add-Ons and Music Add-Ons views, which is less than ideal as it's not a plugin you can do anything with, and will just confuse my wife and kids!

Is this caused by the splitting of service and plugin elements? Would there be any way around not showing the plugin in the libraries, as the end-user can't do anything with it ?