billglover/location-api

This is a simple API written in Go to store and retrieve location objects in MongoDB.

location-api

This is a simple API written in Go to store and retrieve location objects in MongoDB.

location-api's Issues

The GET method is handled but also marked as not implemented

The GET method for /locations is handled on line 31.

    // the following methods have been implemented
    api.Get("/location", handlers.GetLocation)

However it is also marked as not implemented on line 34.

    // the following methods are not implemented
    api.Get("/location", handlers.NotImplemented)

Many thanks to an anonymous GitHub user for reporting this.

Test fail following the limitation to in-day responses for GET requests

When GET /locations responses were limited to only return the results from the current day this meant that automated tests are now failing. Test data isn't available for the current day.

Two potential options for addressing this:

• create test data as the tests run
• make the in-day limitation an optional parameter

Not enough test data to support pagination tests

Build is failing as there is not enough data to support the pagination tests.

--- FAIL: TestAll (0.01s)
    Error Trace:    main_test.go:111
    Error:      Not equal: 1 (expected)
                    != 0 (actual)
    Messages:   GET /locations?page=2&per_page=1 
            unexpected number of objects returned

Pagination handling has no test coverage

Current test coverage does not test whether the following queries return the correct response in all cases

GET http://localhost:8080/locations?page=0&per_page=2
GET http://localhost:8080/locations?per_page=2
GET http://localhost:8080/locations?page=2

Tests should be written to cover pagination query parameters.

MongoDB parameters should be taken from environment variables

The MongoDB parameters are hard coded and should be taken from environment variables. The result is that the code has to change every time we deploy to a new platform.