bingnz/gulp-less-changed

Only pass .less files through the gulp stream if they or their dependencies have changed

gulp-less-changed's Issues

The ability to use the gulp-less-changed without data-uri

hi there

I have a different level of nesting of less files and imports in my project. And when the plugin checks the data-uri, it checks the validity of the URL. But (because of the different level of nesting of files) this may be an invalid URL and then the plugin will return an error. If you put the correct URL - less will not compile base64 from this URL

An simple example:
file _variables.less ( ./styles/base/_variables.less)
@icon: data-uri(../../img/icon.svg);

file styles.less (./styles/styles.less)
@import 'base/_variables'

and icon.svg (./img/icon.svg)

In this case plugin will ok, but in the sourse file data-uri dont compile becouse its invalid url for source file.
if we put @icon: data-uri(../img/icon.svg); Plugin will return an error

Maybe you have an idea how to fix this? Or you can add to the plugin the ability to disable the data-uri. it would be great!
thank

DataUriVisitor doesn't use relative paths

Using the plugin currently causes an error for me. My file structure is generalised as follows:
Content/Product/main.less (Entry Point):
@import "../Thirdparty/other.less"

Content/Thirdparty/other.less:
background-image: data-uri(other.svg)

where other.svg is a file in Content/ThirdParty/

During processing it adds the import as
{ directoryName: "Content/Product", relativePath: "other.svg"}
and as a result it causes an error because the file can't be found.
It should be
{ directoryName: "Content/ThirdParty", relativePath: "other.svg"}

Changing var entryPath = fileInfo.entryPath; to var entryPath = fileInfo.currentDirectory; (Line 43, data-uri-visitor.js) fixes the issue.

Is this by design or can this fix be implemented?

Support for sass/scss

Hi,

Do you think creating a separated version for sass/scss would be too hard?

This plugin is great and a must-have in my opinion.

I have forked this and am trying to make a sass/scss version. Maybe you could point me in the right direction or add support if is not too hard?

Thanks

1.3.2, 1.3.3 broken on gulp 3.9.1

When running on gulp 3.9.1, somehow 1.3.2, and 1.3.3 fails with:

module.js:544
    throw err;
    ^

Error: Cannot find module 'gulp-less-changed'
    at Function.Module._resolveFilename (module.js:542:15)
    at Function.Module._load (module.js:472:25)
    at Module.require (module.js:585:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/site/client/gulpfile.js:10:17)
    at Module._compile (module.js:641:30)
    at Object.Module._extensions..js (module.js:652:10)
    at Module.load (module.js:560:32)
    at tryModuleLoad (module.js:503:12)
    at Function.Module._load (module.js:495:3)

1.3.1 works though.

niv not loading as a dependancy

When running NPM install for gulp-less-changed niv [email protected] is failing from the postinstall, due to npm-install-version not being a dependancy. ( it is a devDependancy, but should be in dependancies)

Makes gulp run slower instead of faster

Here is my setup:

1 stylesheet called "stylesheet.less" which contains about 30 @import statements including random items.

If I try to watch the files separately and build them one by one and concat they can't compile because they depend on another 3-5 stylesheets.

So i thought this module would look at stylesheet.less and only compile imports that have changed. Unfortunately when I try to do just that it makes compiling stylesheet.less 4-5s. When i just remove the lessChanged it goes down to 2-3s.

An in-range update of semantic-release is breaking the build 🚨

The devDependency semantic-release was updated from 15.10.7 to 15.10.8.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

semantic-release is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

Release Notes for v15.10.8

15.10.8 (2018-11-06)

Bug Fixes

• package: update find-versions to version 3.0.0 (669c9ed)

Commits

The new version differs by 1 commits.

• 669c9ed fix(package): update find-versions to version 3.0.0

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of gulp-cli is breaking the build 🚨

The devDependency gulp-cli was updated from 2.1.0 to 2.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

gulp-cli is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

Release Notes for v2.2.0

New

• Honor displayName in ESM exports (190aaeb) - Closes gulpjs/gulp#2270 #189

Build

• Improve tests and raise coverage (2d8a320) - Closes #190

Commits

The new version differs by 3 commits.

• ef58c59 Release: 2.2.0
• 190aaeb New: Honor displayName in ESM exports (closes gulpjs/gulp#2270) (#189)
• 2d8a320 Build: Improve tests and raise coverage (#190)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of less is breaking the build 🚨

The devDependency less was updated from 3.10.1 to 3.10.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

less is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

Commits

The new version differs by 1 commits.

• f454ab7 Rollup changed for Node 4 compatibility (#3421)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

File is always passed through when it's dependencies have a higher modified time that the file

If I have a file with imports that doesn't get updated that often, by having a dependency on that file that is modified, the file will always pass through gulp-less-changed unless I change it's modified time. It should only pass the first time one of its dependencies changes.

Unable to catch an error if an import has errors

If one of the imports has an error I see the console.log output of the error ('Failed to process imports for...') but I'm unable to catch the error thrown using the .on("error", handleError) callback.
I can catch an error if the error is thrown in the file that makes the imports.

An in-range update of sinon is breaking the build 🚨

The devDependency sinon was updated from 8.0.4 to 8.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

sinon is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

Commits

The new version differs by 8 commits.

• 384732e Update docs/changelog.md and set new release id in docs/_config.yml
• dbfe691 Add release documentation for v8.1.0
• cb8f3b7 8.1.0
• 3c6fd39 Update CHANGELOG.md and AUTHORS for new release
• cd27e25 Update @sinonjs/samsam to latest
• 7c79e80 Merge pull request #2199 from RealZogger/getCall-negative
• d851a5e Add clarifying comment for negative indices
• 6d59744 Support negative indices in getCall

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of less is breaking the build 🚨

The devDependency less was updated from 3.11.0 to 3.11.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

less is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

Commits

The new version differs by 1 commits.

• 842386b Fixes #3469 - Include tslib dependency (#3475)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴