bitexpert/disco-demos

Demo applications to showcase how to use Disco.

disco-demos's Issues

Expressive demo

It works nicely with expressive, however I would stick a bit more to the default expressive structure. This has a few advantages:

• It's easier when someone wants to change to disco
• You keep the autoload config functionality in case you need to change settings locally for development or production
• I don't think you want everything in that App\Config class. e.g. if you have 50+ routes, you might want them organized within the config/autoload path.
• Eventually it would be easier to integrate with the expressive skeleton

Files you need to get this working:

• ./config/config.php
  Add this file back and change the last line to

  return $config;

• ./config/container.php

  <?php
  
  use bitExpert\Disco\BeanFactoryConfiguration;
  use bitExpert\Disco\AnnotationBeanFactory;
  use bitExpert\Disco\BeanFactoryRegistry;
  
  // Load configuration
  $config = require __DIR__ . '/config.php';
  
  // Build container
  $beanConfig = new BeanFactoryConfiguration($config['di']['cache']);
  $container = new AnnotationBeanFactory($config['di']['config'], ['expressive' => $config], $beanConfig);
  BeanFactoryRegistry::register($container);
  
  return $container;

• ./config/autoload/disco.global.php

  <?php
  
  return [
      'di' => [
          'config' => \App\Config::class,
          'cache'  => sys_get_temp_dir(),
      ],
  ];

• ./src/App/Config.php
  Obviously you want that file.

Other files like public/index.php don't need to be changed this way.

And finally integrating this with the expressive installer will be a nice challenge.

• The Disco container should only be available when PHP7+ is detected.
• Testing can be done only when PHP7 is loaded on travis or locally.
  Maybe check the php version and mark the test as skipped if it's not compatible?
• Some of the standard configuration files need to be changed (like removing dependencies). One solution could be to generate the config files on the fly and use print_r to regenerate those?
• Also ./src/App/Config.php needs to be generated somehow in case different routers and template engines are going to be installed.

/cc @shochdoerfer @weierophinney

Yii2 demo

Hi @shochdoerfer,

thank you for the talk yesterday, I pointed out a Yii 2.0 Framework demo might be interesting.

There are a lot of changes upcoming in 2.1 see yiisoft/yii2#15436
And here is the new DI container https://github.com/yiisoft/di.

Best regards,
Tobias