keepass2xml import fails with "DOMParser is not defined"

[bitwarden]

keepass2xml import fails with "DOMParser is not defined"

[kspearrin]

I guess we need to polyfill with something like https://www.npmjs.com/package/xmldom

[kspearrin]

Can you build and try master now to see if that resolves the issue? I added the xmldom polyfill.

[edmellum]

Awesome! That gets me past the previous error! 😄 Now I'm getting doc.querySelector is not a function. Maybe try adding a unit test that tries to import a basic KeePass 2 XML file?

[kspearrin]

Looks like xmldom doesnt support querySelector(). Need to figure out a way to support that in Node I guess.

[kspearrin]

Seems to work with jsdom lib. Test here: bitwarden/jslib@93244b5

Try pulling, installing, and building master again and let me know.

[kspearrin]

Nevermind, looks like something broke the build with jsdom. Will have to investigate more.

[kspearrin]

@edmellum Can you give it a try now? Had some issues with webpack and jsdom that should be resolved now. Could you also test it with the packaged binary as well? https://ci.appveyor.com/project/bitwarden/cli/build/artifacts

[edmellum]

The packaged binary works! :D Cloning the repo gives me this error though. "originalMethod.apply(...).finally is not a function"

[kspearrin]

Great. Did you run npm i after pulling?