bitxer/ict1004

This repository contains the source code, in partial fulfilment, of the module ICT1004: Web Systems and Technologies assignment

Hi there 👋🏼 I'm bitxer 👨🏼‍💻

🎓SP-DISM, NUS-ISC | GCFA | OSWE | OSCP

ict1004's Issues

Remove double checking of tokens and session status in routes contained in account.php

Review and remove redundant checks in account.php

Duplicate main tags in post.php

Replace these tags with something else

ICT1004/app/view/post.php

Lines 41 to 47 in 1c0325c

	<main class="card-body">
	<h5 class="card-title"><?= $entry->getField('title')->getValue() ?></h5>
	<p class="card-text blog-post">
	<?php $content = $entry->getField('content')->getValue(); ?>
	<?= $content ?>
	</p>
	</main>

Use REQUEST_METHOD to check post method

Please use the following code sample to check if request method is POST.

$_SERVER['REQUEST_METHOD'] === 'POST'

Below is an example of a code snippet with issue.

ICT1004/app/routes/search.php

Line 10 in a128491

if($_POST){

CSRF token and login_id constant

Add CSRF token by adding the following line.
<input type="hidden" name="<?=FORM_CSRF_FIELD?>" value="<?=$_SESSION[SESSION_CSRF_TOKEN]?>">

ICT1004/app/view/contactus.php

Line 25 in 18c576f

ICT1004/app/view/admin/setup.php

Line 53 in 18c576f

<input type="hidden" name="token" value="<?= $_SESSION['token']; ?>">

ICT1004/app/view/admin/users/specific.php

Line 39 in 18c576f

<input type="hidden" name="_csrf" value="<?= $_SESSION[SESSION_CSRF_TOKEN]; ?>">

Use constant

ICT1004/app/controllers/AccountController.php

Line 125 in 18c576f

$_SESSION['loginid'] = $uid == "" ? $_SESSION['loginid'] : $uid;

css float

float center is not a float value

ICT1004/public/static/css/style.css

Line 131 in 12f0470

float: center;

Wrong field type

Email field type should be email instead of text

ICT1004/app/view/contactus.php

Line 18 in 92d3434

<input class="form-group col-sm" type="text" name="email" value="" pattern="[a-z0-9._%+-]+@[a-z0-9.-]+\.[a-z]{2,4}$" required aria-label="email">