blackburn-labs/proem-ui

A ReactJS framework for fast app development

proem-ui's Issues

Test fail in BitBucket pipeline

BitBucket pipeline is configured in bitbucket-pipelines.yml

The test is executed using a script in package.json (root of project), see the test script.

This uses the following packages to run JS unit tests:

• Jasmine Runs the tests: https://jasmine.github.io/
• Karma Runs Jasmine: https://github.com/karma-runner/karma

This run locally fine, but hangs on BitBucket pipelines:

Implement Storybook

The components folder should have Storybook set up by default: https://storybook.js.org/
This will allow users to browse/test their component library.

This should also include the utils/Icons so that the user can see what icons they have in their library.

Issue with .ca email registration

The RegEx that comes in the CommonUtils requires that someone with a 2-letter email address use capital letters (i.e. [email protected] instead of [email protected]).

Template package.json uses `copyfile` instead of `copyfiles`

npm install error

Using v2.0.0 instead of v2.0.0-beta.0

webpack.prod.js should be in .gitignore

We have separate config files for different levels of environment. The default example template places API keys and APP IDs in this file. This might encourage users to place these sensitive keys/IDs int he code which would then be checked into their Git repo. This is often not best practice.

For the local/edge/dev configurations, this is typically not an issue as those keys are nto as sensitive. However, prod keys/IDs often should be kept secret. This is often done via a CI process or an environment variable of some sort. When it needs to be done locally, I often use .gitignore to prevent the production values from ever making it into their Git, in case they accidentally forgot to take the keys out again. In this case we'd add this file to .gitignore:

• /webpack.prod.js

Should we add this to the template's .gitingore ahead of time?