blackmagic-debug/bmputil

A tool for flashing Black Magic Probe firmware

bmputil's Issues

failed to compile `bmputil v0.1.0 WINDOWS

Hi, here is the issue when I try to follow this instruction for windows:

https://black-magic.org/upgrade.html

installer.c
 C:\Users\zsen_\AppData\Local\Temp\cargo-installlSEQ1w\release\build\libwdi-sys-18360c8dfc8188ff\out\libwdi\libwdi/installer.c(746): warning C4245: '=': conversion from 'int' to 'DWORD', signed/unsigned mismatch
 C:\Users\zsen_\AppData\Local\Temp\cargo-installlSEQ1w\release\build\libwdi-sys-18360c8dfc8188ff\out\libwdi\libwdi/installer.c(693): warning C4245: 'initializing': conversion from 'int' to 'DWORD', signed/unsigned mismatch
 C:\Users\zsen_\AppData\Local\Temp\cargo-installlSEQ1w\release\build\libwdi-sys-18360c8dfc8188ff\out\libwdi\libwdi/installer.c(799): warning C4245: 'initializing': conversion from 'long' to 'uintptr_t', signed/unsigned mismatch
   EMBED  C:\Program Files (x86)\Windows Kits\8.0\redist\wdf\x64\WdfCoInstaller01011.dll
 --- stderr
 [2023-04-25T16:18:13Z INFO  build_script_build] Applying static_windows_error_str.patch to C:\Users\zsen_\AppData\Local\Temp\cargo-installlSEQ1w\release\build\libwdi-sys-18360c8dfc8188ff\out\libwdi\libwdi/libwdi.c
 [2023-04-25T16:18:13Z INFO  build_script_build] Applying installer_path.patch to C:\Users\zsen_\AppData\Local\Temp\cargo-installlSEQ1w\release\build\libwdi-sys-18360c8dfc8188ff\out\libwdi\libwdi/embedder.h
 [2023-04-25T16:18:13Z INFO  build_script_build] Applying winusb_only.patch to C:\Users\zsen_\AppData\Local\Temp\cargo-installlSEQ1w\release\build\libwdi-sys-18360c8dfc8188ff\out\libwdi\msvc/config.h
 [2023-04-25T16:18:13Z INFO  build_script_build] Building embedder host binary...
 [2023-04-25T16:18:15Z INFO  build_script_build] "C:\\Program Files\\Microsoft Visual Studio\\2022\\Community\\VC\\Tools\\MSVC\\14.35.32215\\bin\\HostX64\\x64\\cl.exe" "-nologo" "-MT" "-O2" "-Z7" "-Brepro" "-I" "C:\\Users\\zsen_\\AppData\\Local\\Temp\\cargo-installlSEQ1w\\release\\build\\libwdi-sys-18360c8dfc8188ff\\out\\libwdi\\libwdi" "-I" "C:\\Users\\zsen_\\AppData\\Local\\Temp\\cargo-installlSEQ1w\\release\\build\\libwdi-sys-18360c8dfc8188ff\\out\\libwdi\\msvc" "-I" "C:\\Users\\zsen_\\AppData\\Local\\Temp\\cargo-installlSEQ1w\\release\\build\\libwdi-sys-18360c8dfc8188ff\\out\\libwdi\\libwdi" "-I" "C:\\Users\\zsen_\\AppData\\Local\\Temp\\cargo-installlSEQ1w\\release\\build\\libwdi-sys-18360c8dfc8188ff\\out\\libwdi\\msvc" "-W4" "/Oi" "/Zc:wchar_t" "/TC" "/FeC:\\Users\\zsen_\\AppData\\Local\\Temp\\cargo-installlSEQ1w\\release\\build\\libwdi-sys-18360c8dfc8188ff\\out\\embedder.exe" "-D_CRT_SECURE_NO_WARNINGS" "-D_WINDLL" "-D_UNICODE" "-DUNICODE" "-DWIN64" "C:\\Users\\zsen_\\AppData\\Local\\Temp\\cargo-installlSEQ1w\\release\\build\\libwdi-sys-18360c8dfc8188ff\\out\\libwdi\\libwdi/embedder.c"
 [2023-04-25T16:18:17Z INFO  build_script_build] Building installer_x64...
 [2023-04-25T16:18:18Z INFO  build_script_build] "C:\\Program Files\\Microsoft Visual Studio\\2022\\Community\\VC\\Tools\\MSVC\\14.35.32215\\bin\\HostX64\\x64\\cl.exe" "-nologo" "-MT" "-O2" "-Z7" "-Brepro" "-I" "C:\\Users\\zsen_\\AppData\\Local\\Temp\\cargo-installlSEQ1w\\release\\build\\libwdi-sys-18360c8dfc8188ff\\out\\libwdi\\libwdi" "-I" "C:\\Users\\zsen_\\AppData\\Local\\Temp\\cargo-installlSEQ1w\\release\\build\\libwdi-sys-18360c8dfc8188ff\\out\\libwdi\\msvc" "-W4" "/FeC:\\Users\\zsen_\\AppData\\Local\\Temp\\cargo-installlSEQ1w\\release\\build\\libwdi-sys-18360c8dfc8188ff\\out\\installer_x64.exe" "/Oi" "/Zc:wchar_t" "/TC" "-D_CRT_SECURE_NO_WARNINGS" "-D_WINDLL" "-D_UNICODE" "-DUNICODE" "-DWIN64" "C:\\Users\\zsen_\\AppData\\Local\\Temp\\cargo-installlSEQ1w\\release\\build\\libwdi-sys-18360c8dfc8188ff\\out\\libwdi\\libwdi/installer.c" "/link" "newdev.lib" "setupapi.lib" "user32.lib" "ole32.lib" "advapi32.lib"
 [2023-04-25T16:18:20Z INFO  build_script_build] Running embedder host binary...
 [2023-04-25T16:18:20Z INFO  build_script_build] "C:\\Users\\zsen_\\AppData\\Local\\Temp\\cargo-installlSEQ1w\\release\\build\\libwdi-sys-18360c8dfc8188ff\\out\\embedder.exe" "embedded.h"
 embedder : error: Could not open file 'C:\Program Files (x86)\Windows Kits\8.0\redist\wdf\x64\WdfCoInstaller01011.dll'.
 thread 'main' panicked at 'Embedder executable returned non-zero exit code', C:\Users\zsen_\.cargo\git\checkouts\wdi-rs-b0e544a312a1b829\6fa604b\libwdi-sys\build.rs:534:13
 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: failed to compile `bmputil v0.1.0 (https://github.com/blackmagic-debug/bmputil#1c0a8167)`, intermediate artifacts can be found at `C:\Users\zsen_\AppData\Local\Temp\cargo-installlSEQ1w`

Unhandled libusb error

I was trying to update BMP23 with bmputil 0.1.1 and blackmagic-native-v1_10_0.elf and got the following error:

> ./bmputil flash blackmagic-native-v1_10_0.elf
Found: Black Magic Probe v1.9.1
  Serial: 72ADCDF4
  Port:  1-1
 100% |██████████████████████████████████████████████████| 119.42 KiB/119.42 KiB [232.27 KiB/s 1s]                                                                                                                                                              [2023-11-05T13:33:42Z WARN  bmputil] Possibly spurious error from OS at the very end of flashing: unhandled libusb error: Resource busy
    Caused by: rusb: Resource busy

[2023-11-05T13:33:42Z ERROR bmputil] Error reading firmware version after flash! Invalid firmware?
Error: unhandled libusb error: Overflow
note: recompile with nightly toolchain and run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

Using info afterwards showed:

> ./bmputil info
[2023-11-05T13:40:19Z ERROR bmputil::bmp] Error formatting BlackMagicProbeDevice:
    Black Magic Probe device returned bad data (no product string descriptor) during configuration.
    This generally shouldn't be possible. Maybe cable is bad, or OS is messing with things?
    Caused by: Overflow

Found: Unknown Black Magic Probe (error occurred fetching device details)

What am I doing wrong?

Possibly spurious error from OS at the very end of flashing

I was trying to use bmputil 0.1.1 to upgrade an older BMPM1 with the latest V1.10.0-rc1 firmware and I got the following warning:

❯ ./bmputil flash ../blackmagic-native-v1_10_0-rc1.elf
Found: Black Magic Probe v1.10.0-rc1
  Serial: E2BFB9C6
  Port:  3-1.3.2.4
Erasing flash...
Flashing...
 100% |██████████████████████████████████████████████████| 119.42 KiB/119.42 KiB [4.61 KiB/s 26s]                                                                                        
[2023-10-26T20:35:52Z WARN  bmputil] Possibly spurious error from OS at the very end of flashing: Black Magic Probe device did not come back online (invalid firmware?)
    Caused by: rusb: Input/Output Error

Black Magic Probe successfully rebooted into firmware version v1.10.0-rc1

I'm on macOS 14.0 (23A344) in case that matters.

Is this expected or something I should worry about?

Windows build of bmputil fails - no `cl.exe`

Doesn't surprise me because I've not installed a C compiler but the instructions don't tell me that I need to, or which compiler they prefer. I'm going to guess at a Windows compiler (not gcc) since its "cl.exe".

As an aside, bmputil seems to require a very old instance of the Windows DDK - time for an update for Windows 10/11?

No License

source currently does not provide any licensing information

The Cargo.lock bmputil version does not mach the actual version

This means it is not possible to cargo fetch --locked, which is useful when packaging and for reproducibility in general, because the Cargo.lock needs to be updated and so the command fails.

This is easy to fix for git upstream, and not so important there, but the issue is also present in the archived version in the release, where it's more problematic.