blackthrive/extractss

ExtractSS is an R package for programmatically acquiring and enriching stop and search data from data.police.uk

extractss's Issues

Fix time period summarisation code

Suspect buggy behaviour in time periods that cross years in analyse_records scripts. Inspect and rectify.

Fix typos in readme code examples

For some code examples you're using curly double quotes (“). These need to be changed so the code works when copy and pasted.

e.g. This

lam_har_birm_coords <- subset_coords(coords, la = c(“Lambeth”, “Haringey”, “Birmingham”))

should be this (the colour coding should improve when it's right).

lam_har_birm_coords <- subset_coords(coords, la = c("Lambeth", "Haringey", "Birmingham"))

Improved error message for bad area name

Given you know through show_area_values all the valid values, can you throw an error message if an input to subset_coords is outside that?

For instance, if instead of saying 'Croydon' I say 'croydon', the error I get is a 502 error when it actually tries to query the API.

It'd be more helpful if subset_coords told me in advance something like:

'croydon' is not a valid setset, please run 'show_area_values()' for a list of valid areas.

Where this might especially trip people up is if you put multiple areas in, spelt one of them wrong, you would still get data, but might not immediately spot you had less than you wanted.

Add summary statistics for all ethnicities

Alter existing code to summarise data for all ethnicities and compare between them

EOF within quoted string warning on package install

Warning in scan(file = file, what = what, sep = sep, quote = quote, dec = dec, :
EOF within quoted string

This is happening due to the end of file being detected and potentially has something to do with quotes or the encoding of the text itself. This definitely occurred for the data dictionary, but the latest warnings don't provide a problem file.

Add linux install instructions to readme

Here is a set that worked for me (or at least gives the clue that installr isn't the right approach for linux.

In bash

# install devtools required packages
apt-get install libfontconfig1-dev libharfbuzz-dev libfribidi-dev libfreetype6-dev libpng-dev libtiff5-dev libjpeg-dev

In R prompt:

# install devtools and extractss from github
install.packages("devtools")
devtools::install_github("BlackThrive/extractss")