Giter Site home page Giter Site logo

tslint-config-standard's Introduction

tslint-config-standard's People

Contributors

anchengjian avatar blakeembrey avatar burtharris avatar dependabot[bot] avatar greenkeeper[bot] avatar greenkeeperio-bot avatar mdurling avatar nn--- avatar oojacoboo avatar schickling avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

tslint-config-standard's Issues

Linting for js files

Great work, thank you. This is more a general question than an issue, still I would appreciate some input:

We currently have a mixture of ts/js files in our project and I'd like to lint the js files with tslint as well.

When using the tslint:recommended rules, there are jsRules. tslint-config-standard and tslint-eslint-rules provide no jsRules however.

Is there any package or setting which I could use to have the 'JS Standard Style' linting for js files with tslint?

An in-range update of @types/node is breaking the build 🚨

Version 8.0.8 of @types/node just got published.

Branch Build failing 🚨
Dependency @types/node
Current Version 8.0.7
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As @types/node is β€œonly” a devDependency of this project it might not break production or downstream projects, but β€œonly” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this πŸ’ͺ

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

TSLint v5

Has been released.

And I'm getting this:
Warning: The 'no-use-before-declare' rule requires type checking

There is something in the release notes about it.

An in-range update of @types/node is breaking the build 🚨

Version 8.0.47 of @types/node was just published.

Branch Build failing 🚨
Dependency @types/node
Current Version 8.0.46
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

@types/node is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

WARNING when running with tslint-config-standard

 yr tslint
yarn run v0.28.4
warning package.json: No license field
$ tslint --fix -c tslint.json -p tsconfig.json
WARNING: 'no-unused-variable' lint rule does not need to be set if the 'no-unused-locals' and 'no-unused-parameters' compiler options are enabled.
WARNING: 'no-unused-variable' lint rule does not need to be set if the 'no-unused-locals' and 'no-unused-parameters' compiler options are enabled.
WARNING: 'no-unused-variable' lint rule does not need to be set if the 'no-unused-locals' and 'no-unused-parameters' compiler options are enabled.


Done in 2.31s.

An in-range update of @types/node is breaking the build 🚨

Version 7.0.23 of @types/node just got published.

Branch Build failing 🚨
Dependency @types/node
Current Version 7.0.22
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As @types/node is β€œonly” a devDependency of this project it might not break production or downstream projects, but β€œonly” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this πŸ’ͺ

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

Promises must be handled appropriately

If I use finally, tslint will throw a warning at compile time: "Promises must be handled proper".

19:5 Promises must be handled appropriately
    17 | export default class Home extends Vue {
    18 |   created () {
  > 19 |     this.$axios.get('/')
       |     ^
    20 |       .then((res: any) => console.log(res))
    21 |       .catch((error: any) => console.warn(error))
    22 |       .finally(() => console.log('finally'))
No type errors found
Version: typescript 3.1.6, tslint 5.11.0
Time: 815ms

Everything works fine without finally.
Please fix it.

suggestion: remove no-use-before-declare

I think this rule should be removed. It's not really necessary because no-var-keyword and also it's very slow to compute

Taken from TSlint docs:

Since most modern TypeScript doesn’t use var, this rule is generally discouraged and is kept around for legacy purposes. It is slow to compute, is not enabled in the built-in configuration presets, and should not be used to inform TSLint design decisions.

no-unused-variable is deprecated

no-unused-variable is deprecated. Since TypeScript 2.9. Please use the built-in compiler checks instead.

Should we just disable the rule?

Personally, I'm not a fan of moving lint checks into the compiler, I think... Oh well πŸ€·β€β™‚οΈ

An in-range update of typescript is breaking the build 🚨

Version 2.3.3 of typescript just got published.

Branch Build failing 🚨
Dependency typescript
Current Version 2.3.2
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As typescript is β€œonly” a devDependency of this project it might not break production or downstream projects, but β€œonly” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this πŸ’ͺ

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes TypeScript 2.3.3

This release include a set of bug fixes reported against TypeScript 2.3.2. For the complete list of fixed issues, check out the fixed issues query for TypeScript 2.3.3.

Download:

Commits

The new version differs by 84 commits.

There are 84 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

An in-range update of tslint is breaking the build 🚨

Version 5.5.0 of tslint just got published.

Branch Build failing 🚨
Dependency tslint
Current Version 5.4.3
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As tslint is β€œonly” a devDependency of this project it might not break production or downstream projects, but β€œonly” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this πŸ’ͺ

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes v5.5.0

Editor's note: This release features an important bugfix for overlapping fixes when using --project and --fix (#2864).

πŸŽ‰ New rules and options

πŸ›  Bugfixes & enhancements

Thanks to our contributors!

  • Klaus Meinhardt
  • Josh Goldberg
  • Petr Kosikhin
  • Pablo NΓΊΓ±ez
  • Benny Neugebauer
  • Radon Rosborough
  • reduckted
  • Chris Barr
  • Julian Verdurmen
Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

Remove 'no-unused-variable', 'no-duplicate-key' and 'no-unreachable'

Since I updated tslint to the newest version (v4.4.2), i got the following errors:

no-unused-variable is deprecated. Use the tsc compiler options --noUnusedParameters and --noUnusedLocals instead.

Could not find implementations for the following rules specified in the configuration:
    no-duplicate-key
    no-unreachable
Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed.
If TSLint was recently upgraded, you may have old rules configured which need to be cleaned up.

You should update the rules accordingly...

Warnings when linting

I have some warnings when I lint my source files:

Warning: The 'await-promise' rule requires type information.
Warning: The 'deprecation' rule requires type information.
Warning: The 'no-floating-promises' rule requires type information.
Warning: The 'no-unnecessary-qualifier' rule requires type information.
Warning: The 'no-unnecessary-type-assertion' rule requires type information.
Warning: The 'strict-type-predicates' rule requires type information.

I does not append with tslint:recommended.

My environment:

  • node version 10.15.0
  • typescript version 3.2.4
  • tslint-config-standard version 8.0.1

False positive on interface: "expected onespace after colon in parameter"

Not sure if I should raise here or https://github.com/palantir/tslint/issues

export interface ICodeGenerator {
  description: string
  elementAdded: (id: string) => string
  elementRemoved: (id: string) => string
  clickHappened: (queryPath: string) => string
  inputTextEdited: (queryPath: string, newValue: string) => string
  selectChange: (queryPath: string, event: Event) => string
}

gives error:

image

Using tslint 5.0.0

Edit closed, I was looking at the d.ts file(

An in-range update of tslint is breaking the build 🚨

Version 5.3.0 of tslint just got published.

Branch Build failing 🚨
Dependency tslint
Current Version 5.2.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As tslint is β€œonly” a devDependency of this project it might not break production or downstream projects, but β€œonly” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this πŸ’ͺ

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes v5.3.0

This change may require a change to tslint.json

πŸŽ‰ Notable features & enhancements

Thanks to our contributors!

  • Andy Hanson
  • Klaus Meinhardt
  • Martin Probst
  • Filipe Silva
  • walkerburgin
  • RenΓ© Scheibe
Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

An in-range update of tslint is breaking the build 🚨

Version 5.4.0 of tslint just got published.

Branch Build failing 🚨
Dependency tslint
Current Version 5.3.2
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

tslint is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this πŸ’ͺ

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes v5.4.0

⭐️ Non-breaking API changes

  • The --type-check CLI option now only enables checking for compiler errors before linting. It is no longer required to enable rules that use the type checker -- only need to supply --project now.

πŸŽ‰ New rules, options, and fixers

πŸ›  Bugfixes & enhancements

Thanks to our contributors!

  • Klaus Meinhardt
  • Manuel Lopez
  • Andy Hanson
  • Piotr Tomiak
Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

Using tslint-config-standard produces several warnings

With this tslint.json file:

{
  "extends": [
    "tslint-config-standard"
  ]
}

Running tslint emits several warnings:

$ npx tslint src/file.ts
Warning: The 'await-promise' rule requires type information.
Warning: The 'deprecation' rule requires type information.
Warning: The 'no-unused-variable' rule requires type information.
Warning: The 'no-use-before-declare' rule requires type information.
Warning: The 'no-floating-promises' rule requires type information.
Warning: The 'no-unnecessary-qualifier' rule requires type information.
Warning: The 'no-unnecessary-type-assertion' rule requires type information.
Warning: The 'strict-type-predicates' rule requires type information.

Note that src/file.ts contains no lint issues:

$ cat src/file.ts
console.log('Test')

Is there something I'm missing/doing wrong, or are these warnings expected?

An in-range update of tslint is breaking the build 🚨

Version 5.8.0 of tslint was just published.

Branch Build failing 🚨
Dependency tslint
Current Version 5.7.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

tslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes v5.8.0

⚠️ Deprecations

  • [deprecation] typeof-compare is deprecated because typescript already does that check (#3286)
  • [deprecation] CLI argument --type-check is no longer necessary and will be removed in the next major version (#3322)

⚠️ Updates to tslint:latest configuration

+    "ban-comma-operator": true,
+    "jsdoc-format": {
+        options: "check-multiline-start",
+    },
+    "no-duplicate-switch-case": true,
+    "no-implicit-dependencies": true,
+    "no-return-await": true,

πŸŽ‰ Features

πŸ›  Bugfixes & enhancements

Thanks to our contributors!

  • Klaus Meinhardt
  • Charles Samborski
  • Donald Pipowitch
  • Josh Goldberg
  • mmkal
  • Erik
  • Csaba Miklos
  • Dominik Moritz
  • Khalid Saifullah
  • Lukas Spieß
  • Merott Movahedi
  • Bowen Ni
  • ksvitkovsky
  • Hutson Betts
  • Caleb Eggensperger
  • Brent Erickson
  • Trivikram
  • Brandon Furtwangler
  • Pavel Zet
  • aervin_
  • Holger Jeromin
  • Danny Guo
  • Jeremy Morton
  • Cyril Gandon
  • Andy Hanson
  • yadan
FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Consider adding tslint-sonarts rules

I'm a developer of SonarTS code analyzer, and we have the tslint extension which can be interesting for you. Most of the rules are built to detect bugs and different suspicious patters, they don't generate false positives, and therefore the extension is a good choice for any code base.

Could you give it a try and then consider adding it to your project if you like it? And if you don't, the feedback will be greatly appreciated :)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.