blaskovic / fedora-gooey-karma Goto Github PK
View Code? Open in Web Editor NEWThis project forked from examon/fedora-gooey-karma
http://tirfa.com/gooey-karma.html
License: GNU General Public License v3.0
This project forked from examon/fedora-gooey-karma
http://tirfa.com/gooey-karma.html
License: GNU General Public License v3.0
If I run f-g-k, only one package is available for feedback.
meanwhile-1.1.0-12.fc19
When I run f-e-k, three packages are available for feedback.
fros-1.0-4.fc19.noarch
meanwhile-1.1.0-12.fc19.x86_64
opencv-core-2.4.6.1-1.fc19.x86_64
That means f-g-k detects it wrong. My suspicion is that it doesn't ask Bodhi at all, the reload is too quick. That would be wrong. You can't just load packages from disk and see which ones were installed from updates-testing in the last 7 days. Some of them might have already been pushed stable, and they would be displayed redundantly. Some packages might have be installed 2 or 3 weeks ago, but they can still be in updates-testing, so they would be missing from f-g-k. Some packages could have been downloaded and installed manually, without using a repository. Those would also be missing.
I see no other way than to ask Bodhi on start, similarly to what f-e-k does.
At the moment I need to select a package update on the left side of the app, and then go to the very right side of the app and switch to Comments section. That is very inconvenient (and also very hardly discoverable).
It should be differently. Either all of those could be collapsible sections inside the main pane (similarly to the start tab)
or maybe they could be moved to the top of the main pane and displayed as buttons.
Just some ideas. I'm sure there are even better ones available.
We are unable to break line in comment.
After checking the "karma not submitted" checkbox, the respective packages are hidden, as exepected. But when I uncheck the checkbox, the list of packages is not updated, and the only way to re-fill it is to click on "Load Packages" button.
I have no idea what "Available" button means, but my left list is empty when I click on that button. I think this is somehow related to issue #13. It doesn't matter which packages are installed from which sources. What matters is the current list of packages in updates-testing in Bodhi.
So, unless I miss something, the Installed/Available buttons should be removed.
If "comments" cell contains text with multiple lines, the other fields are vertically aligned to the middle. IMHO it would be better to set vertical alignment to the top.
There is some info here:
https://blaskovicbranislav.wordpress.com/fedora-gooey-karma/
But if the person arrives at github, there's no info how to run the program.
Please include instructions how to clone the program, install dependencies in Fedora and run the program directly in the README.
It might be useful to be able to sort the comments in the list, so I can easily see all the negative/positive karma on one place instead of scrolling through all the entries.
The start tab says:
If you are not sure what you should test, wait until all packages are loaded and see sections below this text.
But most of the packages are not displayed in the tabs below, because the programs are not running neither they have negative karma. The list of packages to test is on the left. The text should be updated to explain that better.
When downloading srpm package, it is downloaded such as:
perl-Pod-Usage-1.66-1.fc21
So the "src.rpm" suffix is missing.
When sending a karma value, I scroll the mouse wheel up on the karma drop-down list to select +1 karma. But I receive -1 karma instead. That is very weird. Direction up should be connected with positive values, and direction down with the negative values, don't you think?
Please re-order from
-1
0
+1
to
+1
0
-1
Also, please consider using radio buttons instead of the drop-down list. It's easier to click once than to click twice to select the value. Also, it could be some nice buttons (big ones, to hit them easily) with emoticon faces on them.
By default, no karma value should be selected, that will make sure the user won't forget the change the value from the previous update.
When I click Send Karma, nothing happens. Then nothing happens. Then I wonder - have I clicked the button? Should I click it again? Then I wait for more eternity. Then I'm instantly switched to a different update.
Please display some indicator that karma value is being sent. Indefinite progress bar, spinner, something. Also, make sure I can't send the comment twice by mistake.
When it's done, switch me to a next update, but make display a green checkbox next the to just-commented update in the left package list? So that I can be sure the comment was sent successfully and I don't need to go back and check.
Since you're the one mostly developing this program now (I assume), the following page is outdated:
https://fedoraproject.org/wiki/Fedora_Gooey_Karma
Please take care of that, because it's the first result when you google up the project name. Make sure it contains up-to-date information or at least redirect to up-to-date information.
Thanks.
It should be possible to resize the "views" (description/bugs/...) manually.
When I click on a package update, I don't see Bodhi comments right away. But I need to see them to be able to test properly. The comments might contain important information what to re-test (-1 karma from some people), or the comments might contain information which program parts were already tested enough and I might decide to test different parts. Or I can learn that this update is totally broken and I don't need to spend my time on it.
The comment section should be displayed on the front page, instead of a second tab. It can be somewhat lighter - for example you could filter out all automated messages from bodhi/autoqa/etc.
I know that there's limited space on the screen. I think that "Yum Info" and "Bodhi Info" sections can be removed from the front page. They are not generally useful and can be part of some "Detailed info" tab. The "Bugs" section occupies a lot of space and could be displayed much lighter. Also it could be displayed only when some bugs are available. The same applies for "Test cases" section.
If you modify these other sections, I think you can fit Bodhi comments right to the front page quite easily.
Please scroll the log (widget at the bottom of the app) from top to bottom, rather than from bottom up. It's much more readable that way.
After clicking on "Load Packages" button, the status bar says:
"All installed packages has been loaded. [Fedora 1]"
It should read (i.e.):
"All installed packages has been loaded. [Fedora 19]"
fedora-gooey-karma.py:
...
def __save_installed_pkg_list(self, pkg_object):
- message = "All installed packages has been loaded. [Fedora %s]" % pkg_object[0]
+ message = "All installed packages has been loaded. [Fedora %s]" % pkg_object
When I try to open an update in a web browser, I see this:
Traceback (most recent call last):
File "/home/kparal/devel/fedora-gooey-karma/src/browser.py", line 50, in show_bodhi_update_in_browser
update = self.main.get_bodhi_update()
File "/home/kparal/.local/bin/fedora-gooey-karma", line 477, in get_bodhi_update
return pkgList[self.ui.pkgList.currentItem().text()]
AttributeError: 'NoneType' object has no attribute 'text'
The GUI should inform the user when no packages are not added to the 'list' (or to be precise none are put into the bodhi_worker queue). This might be caused by several possibilities (as the code is now)
packagesworker.py
def load_installed(self, releasever):
...
if installed_timedelta < installed_max_days:
if rel.startswith('fc') and releasever in rel:
if pkg.ui_from_repo == '@updates-testing':
self.bodhi_workers_queue.put(pkg)
print "putting to queue", pkg
I'd suggest altering the logic a bit (pseudocode):
def load_installed(self, releasever):
...
_updates_testing = False
_max_days = False
_releasever = False
...
if pkg.ui_from_repo == '@updates-testing':
_update_testing = True
installed_timedelta = now - installed
if installed_timedelta < installed_max_days:
_max_days = True
if rel.startswith('fc') and releasever in rel:
_releasever = True
self.bodhi_workers_queue.put(pkg)
print "putting to queue", pkg
So we can inform user via GUI, that no packages are shown since
At the moment, browser (new tab in browser) is opened as a reaction to (probably) on_click event of the Testcases/Bugs lists. I'd consider either making visually clear, that these are hyperlinks which will open the browser, or handling double-click event instead of a single-click.
$ ./src/fedora-gooey-karma
Already up-to-date.
Loaded plugins: langpacks, refresh-packagekit
Traceback (most recent call last):
File "./src/fedora-gooey-karma", line 163, in customEvent
event.callback()
File "/home/kparal/devel/fedora-gooey-karma/src/idlequeue.py", line 33, in idle
func(*args, **kwargs)
File "./src/fedora-gooey-karma", line 290, in bodhi_process_result
line.setText(0, str(comment['text']))
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 129: ordinal not in range(128)
fedora-easy-karma tells me how long ago I installed the package (e.g. 5 days ago, etc). That's a very important information, because I can then assess whether I have seen any problems with that program in the last X days or not. If I don't have the information, I can't decide properly - for example I know that I used that program 3 days ago and it worked great, but I don't know whether the update was installed before that day or after it.
Please display this information visibly somewhere.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.