Support offset based pagination

[yergom]

Support offset based pagination

[bellini666]

Hi @yergom,

The current relay implementation is actually a mix of both. Although it is exposed as a cursor based pagination, it uses an offset strategy. The total number of results is currently exposed at the connection, so you can use that to know the number of pages.

Just like I mentioned in this issue, I'm trying to think of a good way to create a generic solution that could fit both approaches, and also allow the Edge/Connection to be easily expanded by the user. I'm not having much time to work on this right now, but hopefully I'll have next month.

[theGleam]

Any luck with this, @bellini666?

I am happy to help. Would like to start from where you currently are with it.

[bellini666]

Hey @theGleam ,

Don't know what actually needs to be implemented for this, since the current relay implementation uses offset based pagination by default. I also already made some changes to allow someone to easily override it to implement a custom cursor pagination as needed.

But if there's anything else missing still, feel free to open a PR and I'll gladly review it :)

[tasiotas]

hi @bellini666 ,

If current implementation already has offset support, how can I pass it to the query? I can only see cursor parameters, no offset.

purchases is implemented via custom method, it looks like @gql.django.connection doesnt accept pagination=True.
I did set pagination=True on ProductType.

    @gql.django.connection(directives=[IsOwner()])
    def purchases(self, info) -> List["ProductType"]:
        products = (
            Product.objects.filter(order__user__slug=self.slug)
            .annotate(order_number=F("order__order_number"), order_date=F("order__date"))
            .order_by("name")
        )
        return products

@gql.django.type(Product, filters=ProductFilter, pagination=True)
class ProductType(gql.relay.Node):
    name: gql.auto
    slug: gql.auto

    author: Annotated["UserType", gql.lazy("accounts.schema")]

Thank you

[bellini666]

Hey @tasiotas ,

When using a resolver for the connection, you don't have control over the pagination itself. For that you will want to define your own Connection subclass define your custom implementation for from_nodes

Btw, I'm currently contributing the relay integration to strawberry in this PR. Its API has some improvements when compared to the one in this repo, which also includes a better approach for handling custom pagination implementations. And I'll integrate it with this once the PR is released.

[tasiotas]

gotcha! thank you