bleeding182/auth

Get started with the Android Authentication Framework!

auth's Issues

refreshToken can be null under some circumstances

java.io.IOException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull, parameter refreshToken

auth/auth/src/main/java/com/davidmedenjak/auth/AuthCallback.java

Line 43 in d6712db

TokenPair authenticate(@NonNull final String refreshToken)

The easy way of passing in null as refreshToken has been fixed with #5 but you can still pass in null through the AccountManager API:

accountManager.addAccountExplicitly(/*account*/ account, /*password*/ null, /*userdata*/ null)

This value is get-ed at

auth/auth/src/main/java/com/davidmedenjak/auth/OAuthAuthenticator.java

Line 125 in d6712db

final String refreshToken = accountManager.getPassword(account);

(where the docs say that it could be null) but then handled as if it was non-null leading to the exception above.

As refreshToken should be non-null, it should be checked that it's actually non-null and a proper error can be thrown if it's not.

Add option to force token refresh

Allow to request a new access token (and invalidation of the old one)

This will make testing the setup easier and might also help in some edge cases.

Ensure catching of all errors to prevent deadlock

Catch other errors (e.g. NPE due to trying to read empty response body) when catching errors

auth/auth/src/main/java/com/davidmedenjak/auth/OAuthAuthenticator.java

Line 267 in a4b60f7

} catch (TokenRefreshError e) {

Add allowlist as default and block all other apps

Deny other apps access unless they are listed to increase security