blockstream / green_android Goto Github PK
View Code? Open in Web Editor NEWBlockstream Green Wallet for Android
License: GNU General Public License v3.0
Blockstream Green Wallet for Android
License: GNU General Public License v3.0
If SPV trusted node credentials change or my node goes offline, I am locked out of the wallet.
3.0.6
I am connected to my own node via tor. The wallet works as expected. Now turn my node off. Load green wallet. Unlock with pin. I get a spinning animation and am locked out.
After passing the pin/pattern check I should be able to change connection options.
The screen stays blank.
Google Nexus 6 running LineageOS Android 7.1.1
Ledger is successfully detected, I enter PIN, then when asked to open the bitcoin app on ledger it crashes when I do.
Sent crash report.
Under the Settings -> Account -> Bitcoin denomination
menu right now the options are:
It would be great to also have a sats¹ option given the recent growing popularity of the denomination associated with the Lightning Network and the availability of this option in other popular wallet apps and UIs.
¹ satoshis, where 1 BTC == 10^8 sats
Give the users an option to be mandatory use more than one 2fa to spend money and change settings.
Maybe this option could only be available if the user add more than one email and phone as 2fa, like requested here: #23
Hi,
I installed Aegis (https://play.google.com/store/apps/details?id=com.beemdevelopment.aegis) using https://f-droid.org/ on the same phone but on another android profile.
The idea is use 2fa on another profile that doesn't have Green installed.
I setup the 2fa Green on Aegis and it worked ok, but if I change the "seconds" from 30 to 180 on Aegis, the 2fa code on Green doesn't work. With 30 seconds works ok. But with 30 seconds is not enough to me to switch android profiles and insert the aegis 2fa code on Green.
My request here is: be able to use Aegis with any other config that is not the standard 30 seconds.
A lot of privacy concerns can be handled with well guided UTXO management best practices. Power users want to have in depth control over the individual coins. Desktop wallets like Electrum or Wasabi have implemented this already, the same design can be applied to mobile wallets. Blindly using branch and bound might consolidate UTXOs with different historical clusters. This can leak unnecessary metadata.
This is a long-term feature request.
Would really help with maintaining of privacy if we could spend from specific addresses only, mark addresses as 'do not spend', etc.
3.1.0 (Fdroid)
-Samsung Galaxy S9+ SM-G965F/DS (Exynos)
-Lineage OS for microG 15.1 Android 8.1.0
I love this app, but coin control would make it 1,000,000x easier to use.
When an onion address is entered for a trusted peer for SPV, the app throws an error telling the user to set the SOCKS5 Proxy. However, the screen to set that proxy info is hard to find; a shortcut from the settings would be a good idea.
3.1.3
Attempt SPV with a peer over tor before setting proxy info.
Easier location of screen to enter proxy info.
Hard to find proxy screen.
N/A
N/A
None
Downloaded on Android 4.4.2 (Samsung G S3) and the main app icon is much smaller relative to other apps. Downloaded on Android 7.0 (Samsung G S7) and the icon is normal size and looks good.
Version 3.0.6 on Play Store
Icon should be similar size to other icons. Will standout better for users.
Icon is too small
Samsung G S3 4.4.2
Here is a good looking icon on Android 7.0 Samsung G S7
When scanning (24 words) mnemonic it shouldn't wait for me to press OK to go to PIN.
For 27 it should ask for password and then go straight to PIN.
both 3.0.6 and 3.0.7
Scan mnemonic. You will have to press ok to continue.
Scan mnemonic. You won't need to press ok to continue to the next step (PIN)
Hi,
I have three wallets, two of them has 0 balance but was used. (has transactions).When I go to accounts window I would like to see, without clicking on it, that if an account was already used or not.
So I think should have a word on account like (used) or (not used).
Thanks.
Should be able to add more than one email and phone as Two-Factor authentication.
If clicking on a link to say, a donation address, green address automatically opens to the send page. Would be convenient to be able to copy the address to view in a block explorer, or use a different wallet.
Some links that I am opening come from inside apps and the ability to long press the link to copy link address is not available.
3.1.3
error: package com.blockstream.libwally does not exist
master
clone repo
get gdk sdks
try running it via android studio
should run and compile properly
Causes the error mentioned above
macOS Mojave,Android Studio 3.1.3
Build #AI-173.4819257, built on June 4, 2018
JRE: 1.8.0_152-release-1024-b01 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Mac OS X 10.14.1
I understand that you will be adding Bech32 support for address creation in the near future. This is great to have standard but so many wallets like electrum make a critical mistake in UX.
Despite many services upgrading to Bech32 support , there will always be laggards that do not upgrade for years as we have seen historically. Thus it would be great to generate at least one fallback SegWit-P2SH as an option for users that get an error when trying to send to a bc1 address.
I understand there is an incentive for us not to want to support SegWit-P2SH to force businesses to upgrade but a better approach would simply be to allow the user to click a link for 'legacy segwit" that gives them the old SegWit-P2SH address and gives them a warning that the sender is using obsolete address standard and this is costing them more in tx fees when they respend.
Under settings, under "Only Connect to Trusted Node for SPV", I put an onion address. Orbot is active, and Green is added as an app in Orbot. VPN mode is on. Green will not allow the onion address, stating "Tor Connectivity is Disabled!"
However, when I run Bitcoin Wallet for Android, I am successfully able to connect to my node via SPV using the exact same onion address, so I don't think it's an Orbot issue.
This is a v3 hidden service address if that matters.
I may be doing something really stupid, but I've been messing around for a while and can't seem to figure this one out.
3.1.3
Under settings, under "Only Connect to Trusted Node for SPV", I put an onion address. Orbot is active, and Green is added as an app in Orbot. VPN mode is on. Green will not allow the onion address, stating "Tor Connectivity is Disabled!"
SPV connection over Tor.
Error message as described above.
N/A
Xiaomi Mi Mix 2, Android 8.0.0 OPR1.70623.027, MIUI Global 10.2
None
It would be extremely useful if you'd allow custom gap limit option that can be set up only if a user is using their own full node.
Use case: I'm using BTCPay as a merchant and want to see payments in my green wallet, because of the gap limit, I'm unable to see all of the transactions coming from my btcpay.
After typing in the 24 word mnemonic and clicking OK, the error login failed
pops up.
Type in 24 words, press OK. Same error in both main net and testnet, with and without tor.
Accept mnemonic and continue with the wallet setup process.
Login failed, no further process.
One Plus 3, Android v8.0.0, OxygenOS v5.0.8
Great wallet, keep it up!
Feature request: add an option to create bitcoin lightning wallet.
Feature request: add an option to edit accounts.
Auto logout timeout should have option to never logout.
Obs. When Green is minimized and "opened" again, should always ask for fingerprint or pin.
Hi, when I scroll down the transaction list and want to go back to top, sometimes what I see is the refresh function. But what I would like is go to top of window, to see the card.
The latest update says the issue with trezor passphrases has been fixed. It still doesn't work for me.
Green Version 3.0.8
When I plug my trezor in there is indeed fields to enter my passphrase but when I enter it in both fields, and press 'continue', that still doesn't show me my trezor account balance for that passphrase. Instead it shows a message on my trezor asking "Sign message? cancel or confirm". I didn't create any transaction or message that needs to be signed. When I hit 'cancel' it says: "Error logging in with Hardware wallet". And when I, reluctantly, choose 'confirm' it gives me that same message.
I expect it to show me my balance on the trezor and give me the option to spend from it or receive funds to it.
explained above in 'Steps to reproduce'
Trezor One 1.7.3
Google Pixel 2 phone
Android 9
Cannot create a new testnet wallet or mainet wallet from scratch . Tested both on VPN and local uplink. Not using TOR or proxy. Deleted and reinstalled app and tested again. Tested more than 6 times. Cannot restore 24 word seeds either created by blockstream green. Failure always occurs either after confirming the words or entering in the 24 words in restoration where app just hangs or shows an error message where I can close or send error report feedback
green 3.1.3
Android 7.1.1 build - 1 april 2018
HW - LG-M700F
I sent in a report with error logs 30 minutes ago via the app
Requesting a recovery transaction results in an email being sent containing a link to the recovery tool, but clicking the link returns a 404 page error.
3.1.0 (Fdroid)
Request recovery transaction
View email
Click provided link from email
Should take you to the correct github page for the garecovery tool
404 page error when going to https://github.com/greenaddress/garecovery.
Samsung S9+ Android 8.1.0
Items of setting page should appear collapsed:
NETWORK
ACCOUNT
TWO-FACTOR
SECURITY
ADVANCED
ABOUT
Since spending everything in small amount is trivial I assume there is a time factor, or it's only one small spend without 2FA per 2FA logins.
I really like your overall security approach. An important consideration for a wallet (depending on where in the world you live) is if someone is under duress, 2FA won't be enough to stop loss of funds. A few options to address this:
Your wallet is ideally positioned to take advantage of daily limits, time based locks/delays, etc. due to having an online service that validates/approves transactions. Many other wallets won't be able to provide these features.
Does Green 2fa accept HOTP? if no, why?
There's something annoying with the auto-logout:
If I'm using other app and green is opened and logged on background, when the auto-logout happens, the green login window show in front of the other app I'm using.
Could be great if the auto-logout happens on background and do not show green window when I'm using other app.
On main window if I click android back button, Green wallet logout without any confirmation.
Suggestion: show some confirmation message like: click back again will logout Green wallet.
Add an option to hide accounts from accounts list.
version 3.0.7
I get asked to verify PIN, after last digit nothing happen.
I'm sure the verified PIN is good as when entering the wrong PIN it say so.
There should also be a way to back if PIN was wrong
When using the trusted peer for SPV over Tor, the timeout feature automatically logs the user out, which seems to stop the SPV syncing process. It's hard to 100% tell because reopening the app to look at the SPV block notifications causes a new login which restarts the peer connection and the progress bar resets. The notification bar still shows syncing at that point, but it doesn't seem to progress. Upon re logging in, it has to reconnect to the peer over again before picking up where it left off.
UPDATE: It's really just a UX thing with the progress bar resetting rather than it actually stopping syncing. See the next comment in the thread.
Since the SPV syncing takes a while, it would be good if it could continue in the background rather than requiring the user to log back in every 10 mins.
3.1.3
When using the trusted peer for SPV over Tor, the timeout feature automatically logs the user out, which seems to stop the SPV syncing process. It's hard to 100% tell because reopening the app to look at the SPV block notifications causes a new login which restarts the peer connection and the progress bar resets. The notification bar still shows syncing at that point, but it doesn't seem to progress. Upon re logging in, it has to reconnect to the peer over again before picking up where it left off.
Continued background sync on logout, especially for the initial sync.
Timeout kills the sync. See the next comment in the thread.
N/A
Xiaomi Mi Mix 2, Android 8.0.0 OPR1.70623.027, MIUI Global 10.2
None
When Green is minimized and "opened" again, should always ask for fingerprint or pin.
Share receive address button defaults to single app instead of giving options
3.0.6
Click Receive, than click Share Address button
Options to share to different apps like email , whatsapp, text message app and others.
Mine simply defaults to whatsapp which makes for poor UX. Work around is copying to clipboard than opening up email app and pasting address, but this involves more steps.
2 suggested fixes. Ideal = have a popup appear which indicates "share via" and a list of common apps
less ideal = in settings allow one to predefine app to share
Android 7.1.1
From Green Wallet I sent a TX from a p2wpkh address, to a p2wpkh (<--recipient) address and bech32 (<-- change output). The recipient address is showing up in the wallet, but the change address is not.
3.1.2
Should show change addresses.
Does not show address
Android 8.1
It would be great if we're able to export the xpub key from our Green Wallet.
Use Case: I'd like to add xpub key to my BTCPay Server and receive payments directly to my Green Wallet. However, if this is added it's related to #49 since merchants usually need a bit higher gap limit than regular users.
Coldcard USB support, here is the python module https://github.com/Coldcard/ckcc-protocol
Hi,
Blockstream Green has the option to restore or create a new wallet even with a wallet already created or restored. But as you can see you will need mneminic all time to login.
I don't think it should have this option, because only complicate the UX (see image) and if users want to have two profiles of apps, Android has a function called DUAL APPS.
Hello people, I think it would be fantastic to have a separate wallet where the funds have to go through a mandatory wait of x days (user chooses) after entering the second factor code, to avoid physical theft and short term psychological manipulation
steps:
From the UI it seems like the +1 is already pre-entered.
I thought the requirement was to have dashes in the number.
Suggestion, pre-fill "+1" or allow for "1" to mean "+1" and filter out space and dashes "-" in number.
Knots (a Bitcoin core distribution with more features) has added qr code for onion p2p pairing.
We should add a qrcode scanner in SPV settings
App crash when simply logging with a PIN with TOR enabled.
Works fine with Tor disabled.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.