blogdaren/phpforker

A simple Multi-Process programming skeleton written in PHP and learned much from Workerman, which mainly help us to find out how Workerman core works.

phpforker's Issues

why not trigger the Connection::__destruct() only for the first time?

PHPForker/Container.php

Line 1107 in 68ae221

if($cid > 0) unset(Connection::$connections[$cid]);

1. well, first of all, the Connection::$connections is an static array saved some instances of connection
2. just as the title described, why not trigger the Connection::__destruct() when i use unset(Connection::$connections[$cid]) only for the first time?

anyones's help would be appreciate

发现多余代码

代码如下：
`
list($scheme, $address) = explode(':', $this->_socketName, 2);

//only support tcp & udp currently
if(!in_array(strtolower($scheme), array('tcp', 'udp')))
{
self::showHelpByeBye('only support TCP & UDP protocol currently ...'); // 1. unixsocket 直接exit(0);
}

$this->transport = $scheme;
$local_socket = self::$_builtinTransports[$this->transport] . ":" . $address;

//flag
$flags = $this->transport === 'udp' ? STREAM_SERVER_BIND : STREAM_SERVER_BIND | STREAM_SERVER_LISTEN;
$errno = 0;
$errmsg = '';

//create an Internet or Unix domain server socket
$this->_mainSocket = stream_socket_server($local_socket, $errno, $errmsg, $flags, $this->_context);
if(!$this->_mainSocket) throw new \Exception($errmsg);

if($this->transport === 'ssl')
{
stream_socket_enable_crypto($this->_mainSocket, false);
}
elseif($this->transport === 'unix') // 2. 既然都不支持unixsocket 为何还要存在这段代码？
{ // 3.. 这样不是多余了？
$socket_file = substr($address, 2);
$this->user && chown($socket_file, $this->user);
$this->group && chgrp($socket_file, $this->group);
}
`

上面仅支持TCP,UDP，为何还要加入Unixsock 文件创建？Workerman 本身也支持UnixSocket 监听的哦~~~

In the resetStd() method, this line of code self::setOutputStream($STDOUT); in the Base class is the private control permission, but you use the Container as protected.

Base code: static private function setOutputStream($stream = null)
Reset() method error code: self::setOutputStream($STDOUT);

So: static private function setOutputStream($stream = null) is changed to static protected function setOutputStream($stream = null)