blue-jay/core

Core files for Blue Jay.

core's Issues

view.Info contains three mutex values which are copied by the flight package

Commit: e99a706
Code: core/view/view.go

In the view.Info struct there are three fields of type sync.RWMutex - mutex, extendMutex and modifyMutex.

All of these mutexes are used to manage access to reference type fields in the struct - templateCollection, extendList and modifyList. If the struct is copied, the mutexes are copied but the maps and slice referenced by the fields are not. Two goroutines with different copies of the view.Info struct will be working with the same maps and slice but different mutexes. A lock acquired by one goroutine will not prevent access to these fields by another goroutine with a different copy of view.Info.

As I understand it, the mutexes should be outside the struct, in the package.

Edit: I made the first version of this issue far more complicated than it needed to be. Hopefully this is clearer.

Session options in env.json not used in session.go

1. Which commit are you using?
   de61a9f

2. Which operating system, processor architecture, and Go version are you using (go env)?
   Windows 10, Skylake i5 6600k,

3. What did you do?
   Set the session config values in env.json:

	"Session": {
    "AuthKey":"key",
    "EncryptKey":"key",
    "CSRFKey":"key",
		"Name": "sess",
		"Options": {
			"Path": "/",
			"Domain": "",
			"MaxAge": 28800,
			"Secure": false,
			"HttpOnly": true
		}
	},

4. What did you expect to see?
   These config values used

5. What did you actually see?
   The values in the config were not used

It seems like adding the line i.store.Options = &i.Options to the end of session.SetupConfig (before return nil) fixes it. I've been meaning to submit a pull request, but I haven't had the time to write a test yet, so I figured I would file this here in case someone else can get to it first.

Add tests for every package

It's painful, but you have to do it.