Giter Site home page Giter Site logo

bluebillywig-wordpress-plugin's People

Contributors

daanruiter avatar ghultink avatar k-jboon avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar

bluebillywig-wordpress-plugin's Issues

Localizing script with empty value causes PHP warning

Enabling plugin causes following PHP warning right away:

Warning: Cannot assign an empty string to a string offset in ...\wp-includes\class.wp-scripts.php on line 456

I have traced the reason to the following line in the plugin:

https://github.com/DaanRuiter/BlueBillywig-Wordpress-Plugin/blob/7dba70e654a09fb050587c8f4c5e2329ffb6c9e1/bluebillywig.php#L281

If the value happens to be empty string it's not a valid call to WP API and it doesn't handle that case.

JS Player Error

Autoblog.nl is part of WordPress in its multisite mode so it’s not that straightforward in testing. The previous version allowed for the BBW block inside the Gutenberg editor to work just fine and now it doesn’t. And the part not working is not being able to select the video through the BBW Block.

There’s a clear JavaScript error as you can see in the attachment.
CleanShot 2020-10-19 at 16 16 03@2x

Add align wide and full options for BBW block

Gutenberg allows for block to add two additional alignment besided the three default (left, center, right). They're called Align Wide and Align Full.

It would be wonderful to have those options available in BBW and for the player to respect the width of the player to be that what's defined in the WordPress theme. For instance, you can see here at the top image what align wide does for images. The same should work, ideally, for BBW videos as well.

Please tag plugin versions

I understand that plugin isn't formally released yet, but it would be helpful if even early dev releases were tagged.

For my specific need that would be helpful to pull in plugin with Composer into a project.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.