bluebosh/helm-update-config

Helm plugin that allows to update config values of existing release.

helm-update-config's Issues

Using plugin with TLS results in portforward error

I've noticed the following error message when updating a release using TLS:

$ helm update-config "cf.20191121.041748" --set-value env.FLUENTD_LOGDNA_INGESTER_DOMAIN="" --set-value env.FLUENTD_LOGDNA_API_KEY="" --tls-ca-cert=ca.pem --tls-cert=cert.pem --tls-key=key.pem --tls
E1121 18:17:59.275670   26143 portforward.go:303] error copying from remote stream to local connection: readfrom tcp4 127.0.0.1:57864->127.0.0.1:57868: write tcp4 127.0.0.1:57864->127.0.0.1:57868: write: broken pipe
Info: update successfully

The operation does indeed complete successfully. I've seen this portforward error before in my own Golang Helm Client implementations. Does anyone have more information about this? Could the error be potentially suppressed if it does not affect functionality?

update-config -f yaml --set-value returned "panic" when the same multi-layer value is set

This seems a bug from go package strvals. To simplify the issue, I wrote test code for this package:

import	"k8s.io/helm/pkg/strvals"

	m1 := make(map[string]interface{}) 
	m2 := make (map[string]map[string]int)

	m2["key2"]["key1"] = 1
	m2["key2"]["key12"] = 12
	m1["m2"] = m2
	m1["age"] = "12"
        m1["name"] = "simon"
	testStr := string("m2.key2.key1=200")

	fmt.Println("testStr:",testStr)
	fmt.Println("map1:", m1)

	strvals.ParseInto(testStr,m1)
	fmt.Println("after parse:", m1)

Output is

testStr: m2.key2.key1=200
map1: map[age:12 name:simon m2:map[key2:map[key1:1 key12:12]]]
panic: interface conversion: interface {} is map[string]map[string]int, not map[string]interface {}

goroutine 1 [running]:
k8s.io/helm/pkg/strvals.(*parser).key(0xc0000b2860, 0xc00009b950, 0x120917d, 0x14568a0)
	/Users/liujing/go/src/k8s.io/helm/pkg/strvals/parser.go:211 +0xedf
k8s.io/helm/pkg/strvals.(*parser).parse(0xc0000b2860, 0xc00009b950, 0x0)
	/Users/liujing/go/src/k8s.io/helm/pkg/strvals/parser.go:133 +0x38
k8s.io/helm/pkg/strvals.ParseInto(0x149e4ca, 0x10, 0xc00009b950, 0x4a, 0x0)
	/Users/liujing/go/src/k8s.io/helm/pkg/strvals/parser.go:85 +0xbe
cobratest/cmd.funcMapInterface()
	/Users/liujing/go/src/cobratest/cmd/hello.go:416 +0x9b9
cobratest/cmd.glob..func2(0x17f1e00, 0x1817fa8, 0x0, 0x0)
	/Users/liujing/go/src/cobratest/cmd/hello.go:52 +0x62
github.com/spf13/cobra.(*Command).execute(0x17f1e00, 0x1817fa8, 0x0, 0x0, 0x17f1e00, 0x1817fa8)
	/Users/liujing/go/src/github.com/spf13/cobra/command.go:766 +0x2cc
github.com/spf13/cobra.(*Command).ExecuteC(0x17f2060, 0xc000131f88, 0x1007220, 0xc000086058)
	/Users/liujing/go/src/github.com/spf13/cobra/command.go:852 +0x2fd
github.com/spf13/cobra.(*Command).Execute(0x17f2060, 0x0, 0x0)
	/Users/liujing/go/src/github.com/spf13/cobra/command.go:800 +0x2b
cobratest/cmd.Execute()
	/Users/liujing/go/src/cobratest/cmd/root.go:66 +0x2d
main.main()
	/Users/liujing/go/src/cobratest/main.go:20 +0x20
exit status 2

Create pipeline for helm-update-config