"Pick block" to copy items doesn't copy stats

[Bluexin]

"Pick block" to copy items doesn't copy stats

[jredfox]

pickblock event is client only and sends the stack directly to server side.

[Bluexin]

Yeah I know, problem is because we don't send unidentified item data to clients (to prevent hax), the data doesn't get cloned either.

[jredfox]

I made pickblock event on server side only client can't hack the server's code and converted it to forge events found here and here:
https://github.com/jredfox/evilnotchlib/blob/master/src/main/java/com/evilnotch/lib/asm/transformer/GeneralTransformer.java#L28
https://github.com/jredfox/evilnotchlib/blob/master/src/main/java/com/evilnotch/lib/main/eventhandler/PickBlock.java

However don't do what I did or our mods would remain. Is there a way multple overrides of pickblock event could exist?

I did this so silkspawners could properly fetch spawnpotentials while middle clicking a spawner block

[Bluexin]

Thanks.
The server is already notified of the player using "pick block" in a gui though, so I'd rather hook into that directly, see

BlueRPG/src/main/kotlin/be/bluexin/rpg/containers/RPGContainer.kt

Lines 222 to 239 in 9398970

	object SlotTypeUsable : SlotType() {
	override fun handleClick(
	slot: SlotBase,
	container: ContainerBase,
	dragType: Int,
	clickType: ClickType?,
	player: EntityPlayer
	): Pair<Boolean, ItemStack> =
	if (!player.world.isRemote && slot.stack.isNotEmpty && !player.isCreative && clickType == ClickType.CLONE) {
	val r = (player as EntityPlayerMP).interactionManager.processItemUse(
	player,
	player.world,
	slot.stack,
	EnumHand.MAIN_HAND
	)
	if (r == EnumActionResult.PASS) super.handleClick(slot, container, dragType, clickType, player)
	else true to slot.stack
	} else super.handleClick(slot, container, dragType, clickType, player)

[Bluexin]

But anyway, this is low priority compared to some other stuff on the roadmap.