Giter Site home page Giter Site logo

bmad4ever / comfyui_wfc_like Goto Github PK

View Code? Open in Web Editor NEW
3.0 1.0 0.0 115 KB

An "opinionated" Wave Function Collapse implementation with a set of nodes for comfyui

Home Page: https://ko-fi.com/b_mad

License: MIT License

Python 100.00%
comfyui-nodes wave-function-collapse

comfyui_wfc_like's Issues

EZ to implement complementary nodes

  • A node that receives a list of tiles + floats to override sample frequencies.
  • Optional mask batch for Sample node as a way to ignore undesired tiles.

To fix before documenting

  1. Fix the edge case where the initial state is completely filled.
  2. Update tile type counts with the given state tiles at the start.
  3. Change weighting:
    3.1 don't multiply cost w/ entropy.
    3.2 make the extra weight the avg boundary entropy ( or some other, potentially more useful measure ).

Reminder: 1 sample 2 problems

The following generation produces the error below when using desktop ( relevant to reproduce ).

error

... wcf.py", line 283, in update_open_nodes
    wost.remove((y, x))
KeyError: (6, 6)

The type of error, and its "rarity", indicates that it is likely caused by different states having the same hash code.
This problem has been known since day one, and I was not planning on solving it ( using hash codes, is the intended implementation ).

Nevertheless, besides stopping the generation, the error also messes with the progress bar on posterior executions.
Thus, I should implement a workaround to return the best solution and some message/warning that a problem occurred.
Complementarily, I may also take a peek at alternative ways to hash the state.

After deciding what to do/show post error, the state hash code collision problem ( not the problems that arise from this ) should be added to the documentation.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.