bn-d/ppx_subliner

[@@ deriving] plugin to generate Cmdliner sub-command groups, and ppx rewriter to generate Cmdliner evaluations.

ppx_subliner's Issues

invalid handling of parameters in modules

This happens when I try to have a parameter in a module instead of the toplevel. The code that computes the cmdliner term for a type doesn't account for qualified types, I think.

Error message:

File "bin/main.ml", line 14, characters 9-12:
14 |   | B of B.t
              ^^^
Error: Unbound module B_cmdliner_term

Repro:

dune file:

(executable
 (public_name repr_ppxsubliner)
 (name main)
 (flags :standard -warn-error -a)
 (preprocess (pps ppx_deriving_cmdliner ppx_subliner))
 (libraries repr_ppxsubliner))

bin/main.ml:

module B = struct
  type t = {
    file: string; [@pos 0] [@docv "FILE"]
  }
  [@@deriving cmdliner]

  let run (self : t) : unit =
    Format.printf "RUN B@."
end

type cli =
  | Version
  | B of B.t
[@@deriving subliner]

let run (cli : cli) : unit =
  match cli with
  | Version -> Format.printf "version@."
  | B b -> B .run b

[%%subliner.cmds eval.cli <- run] [@@name "test"]

Can't mix subliner with other deriving in script

Great library, but I didn't manage to mix the use of subliner with other deriving libraries.

For example this script:

#!/usr/bin/env ocaml

#use "topfind"
#require "ppx_subliner"
#require "ppx_deriving.show"

type conf = {
    username : string; [@default "pad"]
    debug : bool; [@defaul false]
    command : string; [@pos 0] [@doc "CMD"]
}
[@@deriving subliner, show]

let run (conf : conf) =
  Printf.printf "Hello %s\n" conf.command
  
let () =
   let info = Cmdliner.Cmd.info Sys.argv.(0) in
   let term = Cmdliner.Term.(const run $ conf_cmdliner_term ()) in
   let cmd = Cmdliner.Cmd.v info term in
   exit (Cmdliner.Cmd.eval cmd)

fails to run with

File "/tmp/test.ml", line 12, characters 12-20:
12 | [@@deriving subliner, show]
                 ^^^^^^^^
Error: Cannot locate deriver subliner

If I remove the use of ppx_deriving.show then it works fine.
Looks like we can't have both at the same time. This was working though with ppx_deriving.cmdliner