bngsudheer/ansible-role-dkim

Ansible role to install and configure opendkim

ansible-role-dkim's Issues

multi domain fail

Hi,
dkim_domains:
- example.com
- example.org

i'm trying to setup 4 domains by your example , but ansible generate only first one, and there creates default.private and default.txt

shouldn't it be ?
/etc/opendkim/keys:
domain1/ default.private and default.txt
domain2/ default.private and default.txt

Key generation can be nicer

Now:

- name: Ensure signing key is present
  stat:
    path: "/etc/opendkim/keys/{{ dkim_selector }}.private"
  register: dkim_key

- name: Generate signing key
  shell: /usr/sbin/opendkim-genkey -s {{ dkim_selector }} -d {{ dkim_domains[0] }} -D /etc/opendkim/keys
  when: not dkim_key.stat.exists
  notify:
    - restart opendkim
  tags:
    - skip_ansible_lint

Can be:

- name: Generate signing key
  command: /usr/sbin/opendkim-genkey -s {{ dkim_selector }} -d {{ dkim_domains[0] }} -D /etc/opendkim/keys -b 1024
  args:
    creates: "/etc/opendkim/keys/{{ dkim_selector }}.private"
    warn: false
  notify:
    - restart opendkim