bnussman/beep

Monorepo for Ride Beep App. Ride Beep App 🚕 is a rideshare platform for college students at any colleges and university.

beep's Issues

🔧 Migrate away from `setGoogleApiKey` and `reverseGeocodeAsync`

📝 Description of Refactor

• Migrate away from setGoogleApiKey and reverseGeocodeAsync
• Expo says "Using the Geocoding web api is no longer supported. Use Place Autocomplete instead."
  • I don't really know what they mean by this... I assume they mean we have to implement the API call to google ourselves.
  • If so, this will be a good chance to make the Google API on our server instead of on the client. It will make secrets easier.

✨ Run database migrations with GitHub Actions

📝 Description of Enhcancement

• Automate Database migations with Github Actions

✨ Migrate from yarn to pnpm

📝. Description of Update or Enhcancement

• Lets try pnpminsteadd of yarn

✨ Update to Apollo Server v4

📝 Description of Update or Enhancement

• Update to Apollo Server v4
• Blocked by #38
• https://www.apollographql.com/docs/apollo-server/migration/#migrate-from-apollo-server-express

✨ Update to Expo SDK 45

📝 Description of Update

• Update the App to Expo SDK 45

✨ Update to Expo SDK 47

📝 Description of Update or Enhancement

• Updates the app to Expo SDK 47
  • https://blog.expo.dev/expo-sdk-47-a0f6f5c038af

♻️ Fix Terms of Service and Privacy Policy Formatting

📝 Description of Refactor or Clean Up

• Fix Terms of Service and Privacy Policy Formatting

♻️ Refactor sign up page in app

📝 Description of Refactor or Clean Up

• Refactor app's signup page to use React Hook form
• Improve error states
• improve empty profile picture

✨ Update to `graphql@16` and `type-graphql@2`

📝 Description of Update or Enhancement

• Update to graphql@16 and type-graphql@2
• Follow this up by upgrading to Apollo Server 4

✨ Use Bun for the API

📝 Description of change

• Use Bun for the API and possibly as the package manager

🐛 Rider's app crashes if beeper deletes their car while beeping

🪲 Describe the Bug

• If the rider's app tries to render the car information but the beeper deleted their car, the rider's app will crash

♻️ Better Conditional Authentication

📝 Description of Refactor or Clean Up

• There are places where user can conditionally see private details of another user. For example, when a rider is in an accpted beep, they are allowed to see the beeper's cars. Currently we use a global middleware that catches data, but I think there is a better way to do this

✨ Investigate adding maps

📝 Description of Enhancement

Note: Adding maps will require a rebuild of the app binary on both iOS and Android

Adding Maps looks pretty easy

• Two Places to add Maps
  • Finding a Driver (show map of all beepers within radius)
  • When a beeper is on the way to a rider, show a map for the rider so the rider knows where the beeper is

✨ Investigate switching the API from Node to Bun

📝 Description of Update or Enhancement

• Time to get node out of here
• I feel like the API won't run on bun just yet, but lets see

Cancel beep causing subscription error 🐛

🪲 Describe the Bug

• Beeper canceling a beep is causing a subscription error

✨ Allow users to specify what car they drive

📝 Description of Update or Enhancement

• Allow users to define what kind of car they drive
• Allow users to upload an image of their car
• Add admin features so admins can view cars
• Allow riders to see what car their beeper will be in

Improve `Group Size` client side input and validation

🪲 Describe the Bug

For the group size if you repeatedly click a number you can get a group size of "infinity"

↩️ How to Reproduce

On the Ride menu if you click the group size and press any number repeatedly you can list your group size as "infinity"

📷 Screenshots

Could we get a cap on the group size? I know some people might be able to hold more than 10 people so maybe 30 or less as the group size limit?

♻️ Clean up and Improve Apollo Subscriptions

📝 Description of Refactor or Clean Up

• Switch to lazy: true
• Clean up general logic and cache handling

Update Reset Password Page

Description

• Update the reset password screen of website to match new UI standard
  • Page can be seen at https://ridebeep.app/password/reset/fakeid

Other Items

• Use React Hook Form for the form here
• Make users type the password twice

Current UI

✨ Try React Navigation 7 Static Router

📝 Description of Update or Enhancement

• Try the React Navigation 7 Static Router

🧹 Remove all references to masks

📝 Description of Refactor or Clean Up

• Remove ability to require masks in your car as a beeper

♻️ Rename `photoUrl` to `picture` or `photo`

📝 Description of Refactor or Clean Up

• Rename field
• This will require a db migration

✨ Move `api` from port `3001` to `3000`

📝 Description of Update

Move api to listen on port 3000 just for cleanliness. I made it 3001 a long time ago because 3000 was used by React React App 😮

Confusing Error when Profile Picture is Too Large

When a new user attempts to sign up and uploads a profile picture that is too large, the user sees an error saying "Unexpected token < in JSON at position 0", and graphql returns a 413 error.

Instead, the user should be told that the picture they attempted to upload is too large, and they need to upload a photo smaller than some maximum size.

✨ Premium Chaneges

📝 Description of Update

• Add 🦃
• Show distance on Pick Beep screen
• Consider changing to 2 hours and add other packages like 1, 2, 3, hours

🐛 Android status bar not correct color in dark mode

🪲 Describe the Bug

• Android status bar does not look good in dark mode

↩️ How to Reproduce

• Use dark mode on an Android device

📷 Screenshots

📢 Add deep linking

📝 Description of Feature

• Allow other apps to deep link to our app for getting a ride easier
• See
  • https://reactnavigation.org/docs/7.x/deep-linking#setup-with-expo-projects
  • https://reactnavigation.org/docs/7.x/configuring-links

🔧 How should it work

• Look at how other mapping / rideshare apps do it
  • https://developer.uber.com/docs/riders/ride-requests/tutorials/deep-links/introduction
• Users should be able to open the beep app with a pickup and dropoff location auto-filled
• https://app.ridebeep.app/ride?origin=Charlotte, NC&destination=Boone, NC

✨ Nest the `Change Password` route under `Edit Profile`

📝 Description of Update

• Move Change Password button out of the main drawer and name it visitable by going to Edit Profile and clicking the dropdown in the top right

✨ Try trpc

📝 Description of Enhancement

• Lets try trpc and see if we should switch over :0
• I've been holding off far too long to do this

✨ Investigate Expo Router

📝 Description of Update or Enhancement

• Let's do a POC and see if Expo Router will work well for the app

📦 Update MikroORM from v5 to v6

📝 Description

Update MikroORM from v5 to v6 📦

✨ Update to Expo SDK 46

📝 Description of Update

• Update the app to Expo SDK 46
• Hopefully we can remove our dumb React yarn resolution because of React 18 support

🐛 Android Unknown Login Error

🪲 Describe the Bug

• Android users unable to login?
• Maybe related to the fact we send an Expo Push Token
  • Maybe the token is in some weird format?

↩️ How to Reproduce

• Try to login on Android

📷 Screenshots

♻️ Combine the Beep and QueueEntry into one entity

📝 Description of Refactor or Clean Up

• This was just bad design on my part, it would be nice if all beeps could be a Beep entity (stored in the beep table in the db) rather than having separate tables for QueueEntrys and Beeps
• This will require lots of logic changes for the API

♻️ Password refactor

📝 Description of Refactor

• We need to handle passwords better
• We will need a new column for users that specifies which type of password they have
• New users will have new type of password
• Existing users will have old type of password

MissingRequiredParameter: Missing required key 'Key' in params

Sentry Issue: API-27

MissingRequiredParameter: Missing required key 'Key' in params
  File "/usr/api/node_modules/.pnpm/[email protected]/node_modules/aws-sdk/lib/param_validator.js", line 50, in ParamValidator.fail
    this.errors.push(AWS.util.error(new Error(message), {code: code}));
  File "/usr/api/node_modules/.pnpm/[email protected]/node_modules/aws-sdk/lib/param_validator.js", line 62, in ParamValidator.validateStructure
    this.fail('MissingRequiredParameter',
  File "/usr/api/node_modules/.pnpm/[email protected]/node_modules/aws-sdk/lib/param_validator.js", line 89, in ParamValidator.validateMember
    return this.validateStructure(shape, param, context);
  File "/usr/api/node_modules/.pnpm/[email protected]/node_modules/aws-sdk/lib/param_validator.js", line 34, in ParamValidator.validate
    this.validateMember(shape, params || {}, context || 'params');
  File "/usr/api/node_modules/.pnpm/[email protected]/node_modules/aws-sdk/lib/event_listeners.js", line 132, in Request.VALIDATE_PARAMETERS
    new AWS.ParamValidator(validation).validate(rules, req.params);
...
(5 additional frame(s) were not displayed)

✨ Use Playwright to test app functionality

📝 Description of Update or Enhancement

• Try to use Playwright to test that a beep can happen between two users successfully