board3/board3-portal

Adds a portal with several blocks, which can be switched on and off via the ACP, to the front page of your phpBB 3 forums.

Board3 Portal 2.3.x

Board Portal 2.3.x is a second generation portal for phpBB 3.3.x. It adds a portal with several blocks to your forum. You can change the settings, move the blocks, add new blocks and more in the ACP.

How to use

You can download the current development version of Board3 Portal 2.3.x here or download the current release at www.board3.de. Board3 Portal 2.3.x can be installed via the phpBB 3.3 ACP.

Support

Support for Board3 Portal can be found at www.board3.de or on www.phpbb.com.

Wiki

A wiki with some basic information can be found here: https://github.com/board3/Board3-Portal/wiki

AUTOMATED TESTING

We are starting to have unit and functional tests in order to prevent regressions. You can check our GitHub Actions builds below.

master -

board3-portal's Issues

Correctly redirect to app.php/portal using styleswitcher

Use flag SKIP_DOTS for RecursiveDirectoryIterator

We should use the flag FilesystemIterator::SKIP_DOTS for the RecursiveDirectoryIterator in functions_upload.php. This is supported starting with PHP 5.3. As PHP 5.3.2 is a requirement for phpBB 3.1 this will not break anything.

Poll Modul

Fatal error: Class 'board3\portal\modules\bbcode' not found in \ext\board3\portal\modules\poll.php on line 511

Link testing badge to Board3 Portal in README.md

This currently incorrectly links to phpBB.

Groups are not displayed in the legend "Who is online" Modul

I have fixed with "Display whois_online if module is enabled #226"
Now the groups in the module are "Who's online" is not displayed. Kirk had found this bug

Wrong page title view

controller/main.php line 257
page_header($this->user->lang('PORTAL'));

The page title is displaying exactly the text in parenthesis, not the variable from the language file.

Module clock not work in Internet Explorer 8 / 9

The new clock in 3.1 not work in Internet Explorer 8. In Internet Explorer 9 causes the function "seconds" a slight tremor of the blocks when you scroll to the footer, where the clock is located.

Message: 'length' is null or not an object
Zeile: 23
Zeichen: 2
Code: 0
URI: root/ext/board3/portal/styles/prosilver/template/portal/modules/portal_clock.js?assets_version=1

Fix issues caused by switching to twig in phpBB 3.1

New Event

Request new event for overall_footer and overall_header.html

overall_footer_breadcrumb_before

• Locations:
  • styles/prosilver/template/overall_footer.html
• Since: 3.1.0-a1
• Purpose: Add links to the list at the beginning of the breadcrumbs in the footer

overall_header_breadcrumb_before

• Locations:
  • styles/prosilver/template/overall_footer.html
• Since: 3.1.0-a1
• Purpose: Add links to the list at the beginning of the breadcrumbs in the header

open overall_header.html
Find
[code]<a href="{U_INDEX}" accesskey="h"{$MICRODATA}>{L_INDEX}[/code]

Add before

open overall_footer
Find
{L_INDEX}
In-line Add before

ext/board3/portal/styles/template/event/overall_footer_breadcrumb_before.html
{L_PORTAL}‹

ext/board3/portal/styles/template/event/overall_header_breadcrumb_before.html
{L_PORTAL} ‹

Error messages with the latest version Board3-Portal-develop-2.1.x

I disable the debug mode and the portal no longer works.:

Fatal error: Uncaught exception 'Symfony\Component\DependencyInjection\Exception\InvalidArgumentException' with message '"'\board3\portal\modules\announcements'" is not a valid class name for the "board3.module.announcements" service.' in C:\xampp\htdocs\1219ext\vendor\symfony\dependency-injection\Symfony\Component\DependencyInjection\Dumper\PhpDumper.php:333 Stack trace: #0 C:\xampp\htdocs\1219ext\vendor\symfony\dependency-injection\Symfony\Component\DependencyInjection\Dumper\PhpDumper.php(581): Symfony\Component\DependencyInjection\Dumper\PhpDumper->addServiceInstance('board3.module.a...', Object(Symfony\Component\DependencyInjection\Definition)) #1 C:\xampp\htdocs\1219ext\vendor\symfony\dependency-injection\Symfony\Component\DependencyInjection\Dumper\PhpDumper.php(608): Symfony\Component\DependencyInjection\Dumper\PhpDumper->addService('board3.module.a...', Object(Symfony\Component\DependencyInjection\Definition)) #2 C:\xampp\htdocs\1219ext\vendor\symfony\dependency-injection\Symfony\Component\DependencyInjection in C:\xampp\htdocs\1219ext\vendor\symfony\dependency-injection\Symfony\Component\DependencyInjection\Dumper\PhpDumper.php on line 333

Language string for permissions wrong
// Adding the permissions
'acl_a_manage_portal' => array('lang' => 'Can alter Portal settings', 'cat' => 'misc'),
'acl_u_view_portal' => array('lang' => 'Can view the Portal', 'cat' => 'misc'),

should be

// Adding the permissions
'ACL_A_MANAGE_PORTAL'       => 'Can alter Portal settings',
'ACL_U_VIEW_PORTAL'         => 'Can view the Portal',    

If a registered member, the portal invokes www.forum.de/app.php the error appears. The error does not appear as administrator.

General error

SQL ERROR [ mysqli ]

Unknown column 't.topic_approved' in 'where clause' [1054]

SQL

SELECT COUNT(distinct t.topic_id) as total FROM phpbb_topics t WHERE t.topic_last_post_time > 1388554859 AND t.topic_moved_id = 0 AND t.topic_approved = 1 AND t.forum_id NOT IN (13, 14, 15)

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 803
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 181
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/ext/board3/portal/modules/user_menu.php
LINE: 126
CALL: phpbb\db\driver\mysqli->sql_query()

FILE: [ROOT]/ext/board3/portal/controller/main.php
LINE: 228
CALL: board3\portal\modules\user_menu->get_template_side()

FILE: (not given by php)
LINE: (not given by php)
CALL: board3\portal\controller\main->handle()

FILE: [ROOT]/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php
LINE: 117
CALL: call_user_func_array()

FILE: [ROOT]/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php
LINE: 61
CALL: Symfony\Component\HttpKernel\HttpKernel->handleRaw()

FILE: [ROOT]/app.php
LINE: 29
CALL: Symfony\Component\HttpKernel\HttpKernel->handle()

Temlpate Events for the navigation are missing

Calendar Modul Event

Have to create an event like:
24.09.2014 09:00 All day
Bug error message:
The event start time needs to be in the future

But there is a bug with the time calculation:
Please look http://area52.wintstar.de/phpBBext/viewtopic.php?f=17&t=43#p216

Add new front controller for Board3 Portal

Since the controller interface has been heavily changed, we'll need to add the new controller interface.

Also see https://wiki.phpbb.com/Developing_Extensions and https://wiki.phpbb.com/Controller

Replace colons in HTML files with L_COLON

The colons have been replaced by L_COLON in phpBB files. Do the same in portal files.

Add checker for common misspellings in develop folder

[fixup/theme] Fix incorrect paths to files

Due to the new extension system some paths to files are not correct anymore.
Additionally, add an event listener in order to allow the loading of portal.css.

Remove corners-top ?

If the element corners-top can not be removed?
styles/prosilver/template/portal/_block_config.html
styles/prosilver/template/portal/portal_body.html
and portal.css

Strip ICC profiles from images

Some images contain ICC profiles that should be removed:

Stripped ICC Profile from ./phpBB/ext/board3/portal/styles/subsilver2/theme/images/portal/portal_friends.png.
Stripped ICC Profile from ./phpBB/ext/board3/portal/styles/subsilver2/theme/images/portal/spacer_down.png.
Stripped ICC Profile from ./phpBB/ext/board3/portal/styles/subsilver2/theme/images/portal/spacer_up.png.
Stripped ICC Profile from ./phpBB/ext/board3/portal/styles/subsilver2/theme/images/portal/portal_poll.png.
Stripped ICC Profile from ./phpBB/ext/board3/portal/styles/prosilver/theme/images/portal/portal_friends.png.
Stripped ICC Profile from ./phpBB/ext/board3/portal/styles/prosilver/theme/images/portal/spacer_down.png.
Stripped ICC Profile from ./phpBB/ext/board3/portal/styles/prosilver/theme/images/portal/spacer_up.png.
Stripped ICC Profile from ./phpBB/ext/board3/portal/styles/prosilver/theme/images/portal/portal_poll.png.

Make portal HTML5 valid

Due to changes in HTML5 compared to XHTML 1.0 strict the portal is no longer valid.

Update UMIL to 1.0.5

UMIL 1.0.5 has been released after the release of Board3 Portal 2.0.1. Update it before submitting 2.0.2 to the MOD-DB.

Calendar is displaying days incorrectly

Due to changes in handling the time the HTML is incorrectly created (one for every day). This causes every day to be on a new line.

Fix codesniffer issues

The current issues the codesniffer is reporting should be fixed.

Uploading modules does not work

Due to the changed files, the upload module does not work. Try to fix it or get rid of it.

Fix broken installer

ACP-settings gave error

Language file ./../ext/board3/portal/language/en/mods/portal.php couldn't be opened.

Remove unneccessary entries from info_acp_portal.php

https://github.com/board3/Board3-Portal/blob/develop-2.1.x/language/en/info_acp_portal.php should only contain the titles/names of modules and the categories.

phpbb_topics column topic_approved no longer exists

Due to the new phpBB 3.1 softdelete feature the topic_approved column no longer exists. Replace it with the new topic_visibility column.

Create installer for 3.1

As UMIL gets dropped in 3.1 we'll need to introduce a new installer.

Who is online Bug with Ticket #PHPBB3-11360

The changes with icket #PHPBB3-11360 no longer works the module who_is_online.

The changes in includes/functions.php from
function display($page_title, $display_online_list = true) to
function display($page_title, $display_online_list = false)
gives the error.

PHPunit tests fail locally with current develop-ascraeus

Argument 2 passed to phpbb_database_test_connection_manager::load_schema_from_file() must be an instance of phpbb\db\driver\driver, none given, called in /home/marc/Dokumente/Entwicklung/phpbb/phpBB/ext/board3/portal/tests/testframework/database_test_connection_manager.php on line 19

ACP Language

$user->add_lang_ext('board3/portal', 'portal');

replace with
$user->add_lang_ext('board3/portal', 'info_acp_portal');;

Portal Modul ~ Style switch

To enable the Board Style in the modul "My Board-Style" for registered members and guests, I made ​​the following change:
open root/phpbb/user.php
find
if ($style_request && $auth->acl_get('a_styles') && !defined('ADMIN_START'))
replace with
if ($style_request)

Add unit tests for acp module

Remove duplicate code from moving modules in acp and add tests

News Compact Pagnation not work

Total number of pages is not detected properly

Remove update instructions for old releases

Any update instruction from versions before 2.0.0 should be removed.

Fix display of date of users' upcoming birthdays

Improve look of responsive portal

Redirect users to portal by default

Ajaxify certain actions in the ACP

Actions that could be ajaxified:

• Moving modules up/down
• Add modules
• Removing modules
• Enabling/disabling modules
• Moving modules left/right
• Moving links up/down
• Moving menu items up/down

Reduce amount of tests to same as in phpBB

phpBB has reduced the amount of tests that are run on Travis.
We should do the same.

Idea Responsive Design

The portal on the Smartphone is very overweight. My idea would be permit only a maximum of 5 modules for responsive design. For this function, an additional configuration should be created in the ACP where these modules can be selected. In responsive design, I would find it better that the modules are not side by side but each underneath (accordion) is. For the Tablet view, could allow more modules, then the modules side by side.

Redirect after login redirects to incorrect parent folder

We should use the controller helper for proper redirects.

Move includes files out of portal folder

The includes files are currently inside portal/includes/. As there is no need for this structure in an extension, just move these files to the includes folder.

Move the HTML code of Birthday block to it's html file

Move the HTML part of "{BIRTHDAY_LIST}" and "{BIRTHDAYS_AHEAD_LIST}" from "portal_birthday_list.php" into "birthdays_side.html".

It's for designers currently impossible to change the layout/style of the list.

Enable tests on PHP 5.6 for travis-ci

This PHP version is now available for testing on travis.

Remove converter for Board3 Portal 1.0.6

Add MariaDB environment to Travis-CI

Tests fail on SQLite3

PHP Fatal error: Call to undefined function append_sid() in /home/travis/build/phpBB3/phpBB/ext/board3/portal/includes/functions.php on line 726

PHP Stack trace:

PHP 1. {main}() /home/travis/build/phpBB3/phpBB/vendor/phpunit/phpunit/phpunit:0

PHP 2. PHPUnit_TextUI_Command::main() /home/travis/build/phpBB3/phpBB/vendor/phpunit/phpunit/phpunit:55

PHP 3. PHPUnit_TextUI_Command->run() /home/travis/build/phpBB3/phpBB/vendor/phpunit/phpunit/src/TextUI/Command.php:132

PHP 4. PHPUnit_TextUI_TestRunner->doRun() /home/travis/build/phpBB3/phpBB/vendor/phpunit/phpunit/src/TextUI/Command.php:179

PHP 5. PHPUnit_Framework_TestSuite->run() /home/travis/build/phpBB3/phpBB/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:426

PHP 6. PHPUnit_Framework_TestSuite->run() /home/travis/build/phpBB3/phpBB/vendor/phpunit/phpunit/src/Framework/TestSuite.php:675

PHP 7. PHPUnit_Framework_TestSuite->run() /home/travis/build/phpBB3/phpBB/vendor/phpunit/phpunit/src/Framework/TestSuite.php:675

PHP 8. PHPUnit_Framework_TestCase->run() /home/travis/build/phpBB3/phpBB/vendor/phpunit/phpunit/src/Framework/TestSuite.php:675

PHP 9. PHPUnit_Framework_TestResult->run() /home/travis/build/phpBB3/phpBB/vendor/phpunit/phpunit/src/Framework/TestCase.php:753

PHP 10. PHPUnit_Framework_TestCase->runBare() /home/travis/build/phpBB3/phpBB/vendor/phpunit/phpunit/src/Framework/TestResult.php:686

PHP 11. PHPUnit_Framework_TestCase->runTest() /home/travis/build/phpBB3/phpBB/vendor/phpunit/phpunit/src/Framework/TestCase.php:817

PHP 12. ReflectionMethod->invokeArgs() /home/travis/build/phpBB3/phpBB/vendor/phpunit/phpunit/src/Framework/TestCase.php:951

PHP 13. phpbb_functions_check_file_src_test->test_check_file_src_error() /home/travis/build/phpBB3/phpBB/vendor/phpunit/phpunit/src/Framework/TestCase.php:951

PHP 14. check_file_src() /home/travis/build/phpBB3/phpBB/ext/board3/portal/tests/unit/functions/check_file_src_test.php:40

Only load portal.css on portal page

Not possible to edit event in ACP

It's currently not possible to edit an event. The event is always newly created and the old event stays the same.