boase/be.cqrs

Production implementation of the common domain object repository pattern in a CQRS context

be.cqrs's Issues

Add ASP.NET Core sample with Read Models

States don't support derived types

if B is derived from A then the following method in a state would be triggert

void On(A @event)

CreateCommand with id just does nothing

If a create command is missing a domain object id, the command just get lost.
There is no exception nor a new id with aggregate ist created

Direct Denormalizer Call After Save

Create a possibility to run the denormalizers in a way so that they are called right after saving the event. This way the usage of a messagebus cam be omitted.

This will then make it required to have a simple possibility to run the creation of the read database

Remove GetEventStore from project

"Type" property in log causes conflict with Logstash

Description

When inserting events into the repository, the generated logs use the a Type property:
MongoCommitRepository
Line 194
logger.LogError(e, "Error when saving a commit for {type} {id}", commit.AggregateType, commit.AggregateId);
and Line 203
logger.LogDebug("{Count} events for {Type} - {Id} handled. Result: {Result}.", commit.Events.Count, commit.AggregateType, commit.AggregateId, result.CommitId);

When using structured logs, the Type property is usually already in use by some data processing pipelines, in this particular Logstash, which then can cause errors.

Proposal

Rename the Type property to AggregateType to prevent such conflicts

Log if a updatecommand is queued where no domain object is found

Explain properties of es_Commits collection in docs

Add sample for ASP.NET Core web applications

Goals:

• Show CommandBus usage
• Show CQRS Bootstrapping in ASP.NET Core

@BoasE Is folder name 2_ASPNET_Core/AspNetCoreSample ok?

Register all deperendencies via IServiceCollection, not via configuration objects

See services.TryAdd...

Create BaseCommandHandler

Create BaseCommandHandler from Interface

Issues when duplicate domain object assembly calls

  new EventSourceConfiguration()
          .SetDomainObjectAssemblies(typeof(RealmDomainObject).Assembly)
          .SetDomainObjectAssemblies(typeof(LocalizationDomainObject).Assembly) // <= duplicate assembly
          .SetServiceProviderActivator()

Add Guard for StateActivator in DomainObjectBase

If applyConfig on DomainObjectBase is not called, theres no StateActivator` set which causes NullRefExceptions.

Resolve issues with Rider and Ubuntu

Make all registrations lazy, so that it doesn't block startup

Add DomainObject attribute CreateOrUpdate that doesn't assert

PolicyBase - Policy throw exception when used in method annotation

Linking Examples in readme

To make a more easy way we can link the examples from the readme

Make Loggerfactory optional

Add get by Id method in sample 2

return Id via Location-Header in 202 Accepted response.

net fx support

.net 4.6.1 or lower support

Create sample with logging

UpdateWithoutHistory doesn't assert if the domain object exists

Replace obsolete MongoDb collection.Indexes.CreateOneAsync usages

Replace obsolete MongoDb collection.Indexes.CreateOneAsync usages and use CreateIndexModel instead.

Allow moving/renaming Domain Object

Currently, the full name of the domain object including namespace is persisted. Allow moving or renaming the domain object while keeping backward compatibility, e.g. by providing a mapping from old full name to new full name, either in the configuration or in an attribute.

Rename first sample

New name: 1_NET_Core/NetCoreConsoleSample

Add processes sample

State On() method is not called when parameter is interface

public sealed class CustomerOriginState : StateBase
{
    public void On(IOriginEvent @event) {}
}

public interface IOriginEvent : IEvent
{
    string Origin { get; }
}

Allow to pass serilog enricher for serilog logging config

This would allow to e.g. implement a Enricher (outside BE.CQRS) which handles correlation id and passing the Enricher to the config, the correlation id would also be used in BE.CQRS, thus it wouldn't be a black box correlation logging wise.

Fix broken DomainObjectTests

[xUnit.net 00:00:01.1304280]     BE.CQRS.Domain.Tests.DomainObjectTests.Visiting.WhenVisiting.ItProcessedAppliedAndUncommittedEvents [FAIL]
[xUnit.net 00:00:01.1365290]     BE.CQRS.Domain.Tests.ConventionEventhandlerTests.WhenEventIsRaised.ItCallsTheMethod [FAIL]
Failed   BE.CQRS.Domain.Tests.DomainObjectTests.Visiting.WhenVisiting.ItProcessedAppliedAndUncommittedEvents
Error Message:
 System.NullReferenceException : Object reference not set to an instance of an object.
Stack Trace:
   at BE.CQRS.Domain.DomainObjects.DomainObjectBase.StateInternal[T](Boolean excludeUncommitted) in /Users/alexzeitler/src/github.com/BE.CQRS/src/Domain/Domain/DomainObjects/DomainObjectBase.cs:line 195
   at BE.CQRS.Domain.DomainObjects.DomainObjectBase.State[T]() in /Users/alexzeitler/src/github.com/BE.CQRS/src/Domain/Domain/DomainObjects/DomainObjectBase.cs:line 185
   at BE.CQRS.Domain.Tests.DomainObjectTests.Visiting.WhenVisiting..ctor() in /Users/alexzeitler/src/github.com/BE.CQRS/src/Domain/Domain.Tests/DomainObjectTests/Visiting/WhenVisiting.cs:line 26
Failed   BE.CQRS.Domain.Tests.ConventionEventhandlerTests.WhenEventIsRaised.ItCallsTheMethod
Error Message:
 System.ArgumentNullException : Value cannot be null.
Parameter name: logger
Stack Trace:
   at Microsoft.Extensions.Logging.LoggerExtensions.Log(ILogger logger, LogLevel logLevel, EventId eventId, Exception exception, String message, Object[] args)
   at Microsoft.Extensions.Logging.LoggerExtensions.LogTrace(ILogger logger, String message, Object[] args)

Assert domain object type when using [Update]

create diagrams to document overall concept of BE.CQRS

Create a Sample showing how delete works in CQRS

Create a Sample showing how delete works in CQRS

Commit IDs are empty string

Issue appears repeatedly and with no recognisable pattern so far. The stacktrace is the following:

[11:14:09 ERR] Error handling command "Csi.Identities.Commands.AddPhoneCommand" - '' is not a valid 24 digit hex string.
System.FormatException: '' is not a valid 24 digit hex string.
   at MongoDB.Bson.ObjectId.Parse(String s)
   at MongoDB.Bson.BsonTypeMapper.Convert(Object value, Conversion conversion)
   at MongoDB.Bson.BsonTypeMapper.MapToBsonValue(Object value, BsonType bsonType)
   at MongoDB.Bson.BsonObjectId.Create(Object value)
   at BE.CQRS.Data.MongoDb.Commits.MongoCommitRepository.ByInternalId(String commitId)
   at BE.CQRS.Data.MongoDb.MongoDomainObjectRepository.ByAppendResult(AppendResult result)
   at BE.CQRS.Domain.DomainObjectRepositoryBase.SaveAsync[T](T domainObject, Boolean preventVersionCheck)
   at BE.CQRS.Domain.Conventions.ConventionCommandInvoker.InvokeAndSaveInternalAsync(Type domainObjectType, ICommand cmd, IEnumerable`1 commands)
   at BE.CQRS.Domain.Conventions.ConventionCommandInvoker.InvokeAndSaveAsync(Type domainObjectType, ICommand cmd, IEnumerable`1 commandMapping)
   at BE.CQRS.Domain.Commands.InMemoryCommandBus.HandleCommand(ICommand cmd)

Extensive `had work` / `no work` logging

When using Denormalizers, there's an extensive logging of

had work
no work
no work
no work

Remove Ordinal property on EventCommit

Remove Ordinal property on EventCommit- duplicates functionality

domain object repository should work with type not strings

Support Logging Infrastructure

It should be possible to optin into logging messages i.g. to print them to the console

Idea:

• Support a common LoggingInterface
• Provide da Default Console implementation
• Create Extension Methods for simple bootstrapping

Di / DataContext Classes

to improve dependencies it would be helpfull to have Di-/ Data - Context Classes which can be recieved from the service provider.

this would also reduce the size of the ctor and so son

Denormalizer doesn't work when order of operations are changed

Denormalizer doesn't work if the following order is changed to:

await app.UseRealms();
await app.UseDenormalizer();

instead of:

await app.UseDenormalizer();
await app.UseRealms();

No Exceptions logged in Denormalizer Repository

Given this Customer class:

 public sealed class Customer
    {
        [BsonId]
        public ObjectId Id { get; set; }
        public string Name { get; set; }
    }

And this Repository:

    {
        private readonly IDenormalizerContext context;

        public CustomerRepository(IDenormalizerContext context) : base(context.Db, "Customer")
        {
            this.context = context;
        }

        public Task AddCustomer(string customerId)
        {
            var dto = new Customer
            {
                Id = new ObjectId(customerId)
            };

            return Collection.InsertOneAsync(dto);
        }
    }

When debbuging in Rider, I get this exception:

System.FormatException: String should contain only hexadecimal digits.   at MongoDB.Bson.BsonUtils.ParseHexString(String s)   at MongoDB.Bson.ObjectId..ctor(String value)   at AspNetCoreSample.Denormalizer.Repositories.CustomerRepository.AddCustomer(String customerId) in /home/alexzeitler/src/github.com/BE.CQRS-15/Samples/3_ASPNET_Core_ReadModels/AspNetCoreSample.Denormalizer/Repositories/CustomerRepository.cs:line 18   at AspNetCoreSample.Denormalizer.CustomerDenormalizer.On(CustomerCreatedFromApiEvent event) in /home/alexzeitler/src/github.com/BE.CQRS-15/Samples/3_ASPNET_Core_ReadModels/AspNetCoreSample.Denormalizer/CustomerDenormalizer.cs:line 26

But the application does not log any errors on console.

Set TargetFramework based on OS

Windows: net462
macOS/Linux: netstandard2.0

Update CQRS Samples with new DI Concept