boazy/any-shell-escape

any-shell-escape's Issues

Powershell escaping different from Command Prompt

I'm not sure why but I have to write four quotes which turns out to one in Powershell.

my test.js file

console.log(process.argv);

output on powershell

PS C:\> node test "test two three"
[ 'C:\\Program Files\\nodejs\\node.exe',
  'C:\\test',
  'test two three' ]
PS C:\> node test "test ""two"" three"
[ 'C:\\Program Files\\nodejs\\node.exe',
  'C:\\test',
  'test two three' ]
PS C:\> node test "test """"two"""" three"
[ 'C:\\Program Files\\nodejs\\node.exe',
  'C:\\test',
  'test "two" three' ]

output on command prompt (expected and working)

C:\>node test "test two three"
[ 'C:\\Program Files\\nodejs\\node.exe',
  'C:\\test',
  'test two three' ]

C:\>node test "test ""two"" three"
[ 'C:\\Program Files\\nodejs\\node.exe',
  'C:\\test',
  'test "two" three' ]

C:\>node test "test """"two"""" three"
[ 'C:\\Program Files\\nodejs\\node.exe',
  'C:\\test',
  'test ""two"" three' ]

I'm not sure the best way to fix this because the module only knows if it's windows or linux. My only guess on how to fix this is to add in an argument which tells the module if it's for powershell or command prompt. Thoughts or other solutions to this problem?

UNIX support

This breaks on UNIX systems by adding a dollar sign ($) to the front of a string/file path.

Example:

var escape = require('any-shell-escape');
var url = "/var/www/html/file one.js";
console.log(escape([url]));

returns:
$'/var/www/html/file one.js'
not:
'/var/www/html/file one.js'

Some typos in the README

The README is still referring to shell-escape instead of any-shell-escape, including the title.

Doesn't quote empty strings on Unix

(via)

const test = str => console.log('[' + shellEscape(str) + ']')

test("foo") // => [foo] ✔
test(" ")   // => [' '] ✔
test("")    // => []    ?