Giter Site home page Giter Site logo

Comments (1)

bobbingwide avatar bobbingwide commented on July 24, 2024

The l10n solution needs to be modified to support ACF's PHP blocks which don't require NPM to build them.
As with other block plugins the strings to be translated come from:

  • PHP files
  • block.json files
  • and potentially other JavaScript files

To generate the .pot file to obtain the strings from block.json we can run

wp i18n make-pot . languages/acf-field-block.pot

To translate the strings we need to run l10n.

  • But l10n.php needs to be modified to not run makeoik.
  • Function maybe_do_makeoik(), which currently checks for folders called node_modules and src can alternatively check for a folder called blocks.
  • The blocks folder is currently used in acf-field-block, acf-oik-blocks and oik-testimonials.

It's not necessary to generate the .json files that are normally used during localization of the block
since there is no block JavaScript.
Were it necessary we'd need to run

wp i18n make-json languages --no-purge

We need to call load_plugin_textdomain() to load the language files prior to calling acf_add_local_field_group()
and the block.json file needs the textdomain attribute set to acf-field-block.

from field-block-for-acf-pro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.