Giter Site home page Giter Site logo

Comments (5)

bobbingwide avatar bobbingwide commented on July 2, 2024

In s.b/oikcom I must have created the ACF field blocks for the fields in the Basic group before I created the Layout group.
However I note that the attributes don't show the expected value for the field key ( _acf_field_name ).

<!-- wp:acf-field/acf-field {"name":"acf-field/acf-field",
"data":{"acf-field-name":"text","_acf-field-name":"field_645f589a88304"},
"mode":"edit","backgroundColor":"very-light-gray","fontSize":"normal"} /-->

from field-block-for-acf-pro.

bobbingwide avatar bobbingwide commented on July 2, 2024

However I note that the attributes don't show the expected value for the field key ( _acf_field_name ).

What we see in the data attribute are two values for acf-field-name and _acf-field-name
The value for acf-field-name is the user friendly field name.
The value for _acf-field-name is the ACF internal name for the acf-field-name attribute.
It's NOT the ACF internal name for the text field.

I believe I need to change the code such that the field name is actually the field's key.

from field-block-for-acf-pro.

bobbingwide avatar bobbingwide commented on July 2, 2024

Having done this the HTML for the block is simplified
For the original text field it becomes

<!-- wp:acf-field/acf-field {"name":"acf-field/acf-field",
"data":{"field_645f589a88304":"field_64aa869f48df7"},
"mode":"preview"} /-->

For the cloned field in the Layout group it becomes.

<!-- wp:acf-field/acf-field {"name":"acf-field/acf-field",
"data":{"field_645f589a88304":"field_64abd97b8ff80_field_64aa869f48df7"},
"mode":"edit"} /-->

from field-block-for-acf-pro.

bobbingwide avatar bobbingwide commented on July 2, 2024

It would appear that the simplified version is only temporary; it's what's displayed in the Code Editor when in edit mode.

When saved the data attribute is more complicated.

<!-- wp:acf-field/acf-field {"name":"acf-field/acf-field",
"data":{"acf-field-name":"field_64aa869f48df7","_acf-field-name":"field_645f589a88304"},
"mode":"edit"} /-->

from field-block-for-acf-pro.

bobbingwide avatar bobbingwide commented on July 2, 2024

The value for the acf-field-name attribute in data is now the field's key. This is currently used to generate the classNames for the div.

<div class="acf-field-field_64aa869f48df7 acf-type-text has-text-align- wp-block-acf-field-acf-field">rendered text field</div>

It would be nice to be able to map the key back to the name given by the user.
This would improve the message shown when the field is not set.

<p>Field field_64aa869f48df7 not set for post ID 0</p>

Rather than field_64aa869f48df7 we'd see text.

from field-block-for-acf-pro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.