Comments (5)
In s.b/oikcom
I must have created the ACF field blocks for the fields in the Basic group before I created the Layout group.
However I note that the attributes don't show the expected value for the field key ( _acf_field_name ).
<!-- wp:acf-field/acf-field {"name":"acf-field/acf-field",
"data":{"acf-field-name":"text","_acf-field-name":"field_645f589a88304"},
"mode":"edit","backgroundColor":"very-light-gray","fontSize":"normal"} /-->
from field-block-for-acf-pro.
However I note that the attributes don't show the expected value for the field key ( _acf_field_name ).
What we see in the data
attribute are two values for acf-field-name
and _acf-field-name
The value for acf-field-name
is the user friendly field name.
The value for _acf-field-name
is the ACF internal name for the acf-field-name
attribute.
It's NOT the ACF internal name for the text
field.
I believe I need to change the code such that the field name is actually the field's key.
from field-block-for-acf-pro.
Having done this the HTML for the block is simplified
For the original text field it becomes
<!-- wp:acf-field/acf-field {"name":"acf-field/acf-field",
"data":{"field_645f589a88304":"field_64aa869f48df7"},
"mode":"preview"} /-->
For the cloned field in the Layout group it becomes.
<!-- wp:acf-field/acf-field {"name":"acf-field/acf-field",
"data":{"field_645f589a88304":"field_64abd97b8ff80_field_64aa869f48df7"},
"mode":"edit"} /-->
from field-block-for-acf-pro.
It would appear that the simplified version is only temporary; it's what's displayed in the Code Editor when in edit mode.
When saved the data attribute is more complicated.
<!-- wp:acf-field/acf-field {"name":"acf-field/acf-field",
"data":{"acf-field-name":"field_64aa869f48df7","_acf-field-name":"field_645f589a88304"},
"mode":"edit"} /-->
from field-block-for-acf-pro.
The value for the acf-field-name
attribute in data
is now the field's key. This is currently used to generate the classNames for the div.
<div class="acf-field-field_64aa869f48df7 acf-type-text has-text-align- wp-block-acf-field-acf-field">rendered text field</div>
It would be nice to be able to map the key back to the name given by the user.
This would improve the message shown when the field is not set.
<p>Field field_64aa869f48df7 not set for post ID 0</p>
Rather than field_64aa869f48df7
we'd see text
.
from field-block-for-acf-pro.
Related Issues (20)
- Cater for field type `google_map` HOT 2
- Internationalize and localize acf-field-block HOT 1
- Ensure ACF field block output supports different settings of the `align` attribute
- Checkbox rendering not working after cloning HOT 2
- Taxonomy rendering not working after cloning HOT 1
- Develop in situ PHPUnit tests HOT 5
- Cater for Inactive groups HOT 1
- Rename acf-field-block to Field block for ACF PRO - permalink: field-block-for-acf-pro HOT 2
- Support for PHP 8.1 and PHP 8.2 HOT 1
- Update documentation since the blocks have the wrong field name in the editor HOT 2
- Improve plugin to satisfy wordpress.org requirements HOT 1
- Add option to display the field's label HOT 1
- Sort field names by title and improve field identification if possible HOT 1
- Teething problems with v1.3.0 on s.b/cwiccer HOT 8
- Get values from options page
- Add support for the icon picker field type
- Cater for fields with no value
- Google Chrome autocompleting Email and Password fields HOT 1
- Cater for field type `clone` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from field-block-for-acf-pro.