bogdantimes/trading-helper

Simple to use and secure autonomous trading bot with WEB application.

trading-helper's Issues

Maximum observed price that is used for swing trading is not reset after selling

Regression in profit and commission calc

Debug msgs:

Bought

"{\"symbol\":\"KNCUSDT\",\"orderId\":333848539,\"orderListId\":-1,\"clientOrderId\":\"6D6ib3METsKhO12rV2jIna\",\"transactTime\":1651001137835,\"price\":\"0.00000000\",\"origQty\":\"48.40000000\",\"executedQty\":\"48.40000000\",\"cummulativeQuoteQty\":\"249.93760000\",\"status\":\"FILLED\",\"timeInForce\":\"GTC\",\"type\":\"MARKET\",\"side\":\"BUY\",\"fills\":[{\"price\":\"5.16400000\",\"qty\":\"48.40000000\",\"commission\":\"0.00048498\",\"commissionAsset\":\"BNB\",\"tradeId\":25524409}]}"

Sold

"{\"symbol\":\"KNCUSDT\",\"orderId\":334040960,\"orderListId\":-1,\"clientOrderId\":\"YRPWjV2SdkOie9jgDkOgIj\",\"transactTime\":1651007989734,\"price\":\"0.00000000\",\"origQty\":\"48.40000000\",\"executedQty\":\"48.40000000\",\"cummulativeQuoteQty\":\"255.68040000\",\"status\":\"FILLED\",\"timeInForce\":\"GTC\",\"type\":\"MARKET\",\"side\":\"SELL\",\"fills\":[{\"price\":\"5.28300000\",\"qty\":\"40.00000000\",\"commission\":\"0.00041027\",\"commissionAsset\":\"BNB\",\"tradeId\":25537438},{\"price\":\"5.28100000\",\"qty\":\"8.40000000\",\"commission\":\"0.00008612\",\"commissionAsset\":\"BNB\",\"tradeId\":25537439}]}"

Result:

Selling 48.4 of KNCUSDT
KNCUSDT: Sold. => price=5.282  gained=255.6804 profit=255.49

Old stable coin is used when buying more of existing asset even after stable was changed

Description

When buying more of an existing asset after changing the stable coin, the asset is still paid by the stable that was used previously.

For new assets, the new stable coin works.

Trade result quantity is sometimes rounded to wrong number resulting in error

Example.

Logs:
Selling 14.350000000000001 of TORNUSDT

Errors:

Exception: Request failed for https://api1.binance.com/ returned code 400. Truncated server response: {"code":-1111,"msg":"Precision is over the maximum defined for this asset."} (use muteHttpExceptions option to examine full response)

If BNB is present in the assets and fee was paid using BNB - update it's balance

Description

Same applies to any other swap, when gained or paid cryptocurrency is present in the current Assets and the paid or gained quantity has to be removed or added from the balance of the tracked asset.

Take for example the following real life situation, steps:

1. USDC bought using USDT
2. Stable Coin switched to USDC in the Settings
3. ETH bought using USDC

Expected:
USDC quantity in the Assets should be reduced by the amount paid for ETH.

In the BNB case, if BNB is present - the fee should be reduced from it's balance,
if BNB is not present in the assets, but fee was paid using BNB, the fee should be converted to stable coin price and reduced from the calculated profit.

Weird javascript rounding issue in Settings tab for Profit / Loss limits

Entering 7 results in the following

Also, you cannot enter fractions.

Reset button on Survivors tab crashes the UI

Description

Reset button makes the Survivors scores reset on the backend side, but the UI crashes. Only page reload helps after that.

Any error that follows a successfully trade can leave the asset in incomplete buy/sell state

In some cases changing asset name (for example EPS -> EPX) can cause a corrupted state

Description

A pretty rare case, but,
If you make editing with coin name renaming, and background Process is running,
during editing, an old asset is removed,
but because the changeTrade API is returning an empty TradeMemo for non-existing anymore asset,
the Process can re-create an asset that was removed, and it will be in an incorrect/broken state.

Feature: Profit based Stop Limit

Description

/**
   * When ProfitBasedStopLimit is true - a stop limit for each asset is calculated based on the total profit of the tool.
   * All profit is divided equally between all assets and this amount is how much loss is allowed for each asset.
   * Such stop limits are always recalculated when the total profit or number of assets changes.
   * Overrides {@link StopLimit}.
   */

Alerts for crossing profit limit are repeated

When price crosses up the profit limit, the alert is sent.
Noticed that the alert is sent repeatedly a few more times, although the price seems to be above the profit limit already, e.g. no crossing up happened again.

Averaging down tries to invest into stablecoins when there are no other assets

"Add" dialog for entering trade details manually is needed