bogdanvlviv/minitest-mock_expectations

minitest-mock_expectations's Issues

Asserting call to method with array argument fails

Hi, great job on this gem!
I found a pretty serious bug though :(

If you try to assert a call to a method that takes an array as its argument:

assert_called_with(Tempfile, :new, [['hello', '.jpg']]) do
  file = Tempfile.new(['hello', '.jpg'])  
end

Running the above code will result in:

ArgumentError: mocked method :call expects 2 arguments, got 1
from .../ruby-2.6.3/gems/minitest-5.14.0/lib/minitest/mock.rb:150:in `method_missing'

This happens due to a collision with the feature of being able to pass an array of different sets of arguments that the method can be called with.

I suggest changing the interface of the multiple arguments feature to the following (which will also allow providing a different return value for each set of arguments):

expectations = [
  { 
    expected_args: ["Thanks for sharing this."],
    return_value: mocked_comment_1
  },
  { 
    expected_args:  ["Thanks!"],
    return_value: mocked_comment_2 
  }
]

assert_called_with(@post, :add_comment, expectations: expectations) do
  @post.add_comment("Thanks for sharing this.")
  @post.add_comment("Thanks!")
end

Shall I open a PR for this?

Extend `assert_called_with` to allow providing a different return value for each set of arguments

The initial idea of this looks like:

expectations = [
  { 
    expected_args: ["Thanks for sharing this."],
    return_value: mocked_comment_1
  },
  { 
    expected_args:  ["Thanks!"],
    return_value: mocked_comment_2 
  }
]

assert_called_with(@post, :add_comment, expectations: expectations) do
  @post.add_comment("Thanks for sharing this.")
  @post.add_comment("Thanks!")
end

See the request in #4
See related discussion in #5

Thanks and minor suggestion

Hey, this is a great life saving gem. It brings the nice RSpec expectations easily and intuitively into my Rails projects, so thanks for that.

One thing I noticed - it is hard to find this gem. Searching "minitest mock expectations" does not show this repo anywhere in the first pages, and I don't remember even how I did find it - perhaps changing the README H1 to "Minitest Mock Expectations" will help Google?