bookuha/elibrary

elibrary's Issues

Clean entities from redundant initializations

string a = "something" is bad.
= null is good.

Move *Entity*Response to the Application/*Entity* folder

For example we have a BookResponse (DTO) in Application.Shared, but It would be way more easier to locate it in the folder along with the classes that use it.
So, it can be moved to the Application/Books folder where it serves as a response for handlers.
But the problem is it references Infrasturcture for mappings methods, and Infrastructure must reference this DTO to make maps, therefore Circular Reference is produced.
The problem is solved by introducing 3rd party mappers.

Behavior based services

Do not have
EntityService that does all the job related to all entity's fields, but
EntityBoundaryService1,2 that split them by boundaries

Group Command & Handlers up in more proper way

DB Validation

Use EF FluentAPI to configure some DB validation

Should Application (IServiceException) know about HTTP? (error codes)

Should it be delegated to UI layer?
Remove status codes from IServiceException. Make UI layer resolve them based on error type received

e.g. if error is IdNotFound return 404

Task Based UI

I feel this one is way more appropriate.

Request & Entity validation

Use FluentValidation to validate both requests and entities

Pass Commands to Controllers

DTOs are seem redundant here.
Make controllers receive commands directly, so MediatR request validation can be done appropriately. (MediatR Pipeline)
It is just seem more proper and cleaner

Move EF Configurations to files

Currently they all are located in DbContext OnModelCreating method

Split service registrations in different methods

Make it
AddApplication()
AddInfrastructure()
...