Show that link to the book is being moderated

[skobkin]

Show that link to the book is being moderated

[skobkin]

@prolibre

I think these duplicates are linked to a bug

Good catch.

I didn't know that he didn't have the moderation information

Here's how it works for links to new domains:

1. User adds the link.
2. User do not see anything.
3. Administrator gets a notification about pending link domain review.

GIF with demonstration

P.S. I guess some of those duplicated links could be caused by #2988 and some by UI flaws.

[MaggieFero]

I know on my instance I've seen a bunch of what looks to be a user being frustrated and not just the bug causing duplicates, this warning sounds very nice!

[skobkin]

An example of such federated book:

[prolibre]

I think these duplicates are linked to a bug (when books circulate between instances). But that doesn't mean that the user shouldn't be warned (I didn't know that he didn't have the moderation information).

[skobkin]

And guess what happens if users tries to add link again?

[MaggieFero]

I went to see if I could handle this quickly, and there is a line in the FileLinkForm that I would expect to do this (added by Mouse two years ago, per git blame).

I confirmed on my own instance by deliberately adding two copies of a link to the last book I read. I never got this warning, and when I approved the domain both appeared. So it seems like this may just be a small bug?

Line 49 of https://github.com/bookwyrm-social/bookwyrm/blob/main/bookwyrm/forms/links.py is the exact warning I'd expect to see here, in case somebody else has a chance to get to it before I do!

[skobkin]

#3311 probably fixes accidental duplication. Not sure if it helps to know WHY the link is not being shown yet.