booligoosh/rubiks-time

A clean, modern Rubik's cube timer

rubiks-time's Issues

Starting and stopping broken

When pressing space, I get the following errors logged into the console:

ReferenceError: event is not defined script.js:167:1
spaceDown https://booligoosh.github.io/rubiks-time/script.js:167:1
onkeydown https://booligoosh.github.io/rubiks-time/:1:1

ReferenceError: event is not defined script.js:189:1
spaceUp https://booligoosh.github.io/rubiks-time/script.js:189:1
onkeyup https://booligoosh.github.io/rubiks-time/:1:1

This happens on Firefox 52.0 (64bit) with Ubuntu 16.10.

Remove extra lines when too less solves are done

If no average of 5/12 can be done because of too less solve, the <hr>s are still there and look bad. I would suggest do display only 1 <hr> at the bottom.

This is how your code looks in the browser with 0 solves:

<div id="screen6" style="display: block;">
    <!-- Some more unimportant code -->
      <hr>
      <h2 id="average">Average - NaN:NaN.NaN</h2>
      <hr>
      <h2 id="currentaverageof5"></h2>
      <hr>
      <h2 id="bestaverageof5"></h2>
      <hr>
      <h2 id="currentaverageof12"></h2>
      <hr>
      <h2 id="bestaverageof12"></h2>
    </div>

and these are the visible elements:

<div id="screen6" style="display: block;">
    <!-- ... -->
      <hr>
      <h2 id="average">Average - NaN:NaN.NaN</h2>
      <hr>
      <hr>
      <hr>
      <hr>
    </div>

Average is NaN with 0 solves

To reproduce, clear all solves.
Click on "Stats", then click on "More Stats".
It shows you "Average - NaN:NaN.NaN".

While this is understandable for any JavaScript programmer, any other person will think, that the timer is broken.

Possible solutions are displaying "DNF", "00:00.00" or "can not calculate". You can do this in averageOfArray (line 260 in script.js) by checking like if(array.length<1)return"DNF".