boostryjp/ibet-network

ibet Blockchain Network 🔗

ibet-network's Issues

[FEATURE]運用改善

現状の課題

geth起動後、起動確認可能なメッセージを出力してほしいとのリクエストがあった。
また、他アプリコンテナがDockerのヘルスチェック句を利用するため、見た目をそろえるために追加する。

ソリューション案

geth正常起動後、メッセージを出力する。
あわせてヘルスチェックステータスを表示可能なようにhealthcheck.shを追加する。

代替案

上記の他に代替案がある場合は記載してください。

その他

その他の特記事項がある場合は記載してください。

[BUG]change docker-compose for local-network

Describe the bug
Local network's configuration file lacked options.

[FEATURE]Change static-nodes.json for general node.

Is your feature request related to a problem? Please describe.

• Regular update of ibet network will be done in July 2021.
• We will change static-nodes.json for general nodes.

Describe the solution you'd like

• As above.

[FEATURE] alpine upgrade

Is your feature request related to a problem? Please describe.

• Regular update of ibet network will be done in July 2021.
• At this timing, we would like to upgrade the base image (alpine) of the Quorum container for security and other reasons.

Describe the solution you'd like

• alpine v3.12.0 -> v3.13.0

[FEATURE]構築手順を記載する

現状の課題

Githubのリポジトリを見ただけで構築を行えるようにする

ソリューション案

手順を記載する

代替案

上記の他に代替案がある場合は記載してください。

その他

その他の特記事項がある場合は記載してください。

[FEATURE]Readmeの作成

現状の課題

• 現状、Readmeが作成されていない状態。

ソリューション案

• Readmeを作成する。

[FEATURE]Describe the version information

Is your feature request related to a problem? Please describe.

• Describe the concept of the ibet-Quorum version.
• Describe the version upgrade of quorum once every six months.

Describe the solution you'd like

as above

[BUG]General用docker-composeファイルがGeneral用ではない

バグの説明

・https://github.com/N-Village/tmr-quorum/blob/master/quorum-prod-general/docker-compose.yml
・上記ファイルはGeneral用途のはずだが、Validator用になっている。

正しい状態（想定）

・General用途のdocker-composeファイルを作成すべき。

[BUG] Block synchronization stops with syncmode=fast in General node

Describe the bug

Version: v1.2.0 (GoQuorum:v21.7.1)

Prerequisite: Validator nodes were built using v1.2.0.

• In a network built with v1.2.0, block synchronization stopped when starting a General node (non-Validator) with default startup (syncmode=fast).
• The startup command is as specified in run.sh.
• With synchronisation failing, the following log is output.

DEBUG[11-25|01:43:54.016|eth/fetcher/block_fetcher.go:723]     Discarded delivered header or block, too far away peer=81a7723709e695d8 number=2227 hash="402a21…2ad154" distance=2227D
EBUG[11-25|01:43:54.017|eth/fetcher/block_fetcher.go:393]     Peer discarded announcement       peer=102635096c3ebf17 number=2227 hash="402a21…2ad154" distance=2227
DEBUG[11-25|01:43:54.031|eth/fetcher/block_fetcher.go:393]     Peer discarded announcement       peer=336fcbbd0e44ddb9 number=2227 hash="402a21…2ad154" distance=2227
DEBUG[11-25|01:43:54.035|eth/fetcher/block_fetcher.go:393]     Peer discarded announcement       peer=5b0c2e93e76db53c number=2227 hash="402a21…2ad154" distance=2227

• After some investigation, it seems that this problem is solved when geth is started with syncmode=full.

Additional context

• The settings for genesis.json and static-nodes.json for the environment where the problem occurred can be found at the following link.
• https://github.com/BoostryJP/ibet-Network/tree/v1.2.0_beta5/test-network

[FEATURE] Upgrade golang

Is your feature request related to a problem? Please describe.

Several vulnerabilities have been detected in the golang we are currently using.

• https://nvd.nist.gov/vuln/detail/CVE-2021-27918
• https://nvd.nist.gov/vuln/detail/CVE-2021-3114

Although the above vulnerabilities are not a problem in the ibet network, we would like to upgrade golang as a precaution.

Describe the solution you'd like

We would like to upgrade to the latest version of 1.16.

[FEATURE]blockexplorerの導入

現状の課題

• 開発、システム運用で、トランザクションの状況を追う機会は多いが、都度コマンドを叩いてチェックするのは負荷が高い。

ソリューション案

• blockexplorerを導入する。
• epirusを導入する。

[FEATURE]リポジトリ名の変更

現状の課題

tmr-quorum -> ibet-Quorum

[FEATURE] Remove unnecessary init

Is your feature request related to a problem? Please describe.

• In the run.sh of ibet-network and test-network, the process of geth init is performed.
• However, it is not necessary to execute geth init in run.sh because the command is executed beforehand.

Describe the solution you'd like

• Remove unnecessary geth init in the run.sh.

[FEATURE] Specify the execution environment for local network

Is your feature request related to a problem? Please describe.

• In the docker-compose definition of local network, there is a definition of the volume mount of /home/ubuntu.
• In other words, the ubuntu environment is assumed as the execution environment.

Describe the solution you'd like

• It seems necessary to specify that the default running environment for local network is ubuntu.

[FEATURE] Quorum Version Up Test (July 2021)

• Version selection for July 2021.
• Test the version up.
• Summarize the impact on the consortium participants.

[FEATURE]リポジトリの管理方法が明記されていない

現状の課題

他リポジトリのPMリポジトリのように、管理フローなどがない

ソリューション案

管理フローを記載する

代替案

上記の他に代替案がある場合は記載してください。

その他

その他の特記事項がある場合は記載してください。

[FEATURE] Change the connection destination for general node

Is your feature request related to a problem? Please describe.

• The Validator network will be geographically distributed to AWS Osaka region in ibet-network and ibet-fin-network.
• As a result, the IP address of Bridge node will be changed, and the connection destination of General node will be changed.

Describe the solution you'd like

• Change the setting of static-nodes.json of general node.

Additional context

• Since the IP address and enode information will be finalized after the construction of the bridge node, change the settings after the construction.

[FEATURE] Quorum upgrade (January 2022)

The network will be regularly updated in January 2022.

Details of the upgrade

• Quorum version upgrade

  • Version to be adopted is under consideration.
  • Version to be fixed in Oct 2021.

• We plan to use v21.7.1.

[BUG]General用のコンテナ起動引数にnodekeyhexは不要

バグの説明

・現状、General用のDockerコンテナ起動引数にnodekeyhexが必要になっているが、本来は不要。
https://github.com/N-Village/tmr-quorum/blob/5dbfc67fcf7e5864d277502d4ebc25b4df9a15b4/quorum-prod-general/run.sh#L16

正しい挙動（想定）

・nodekeyhexが引数になくても起動できるようにする。

ibet logo

[BUG] Unavailable modules in HTTP API list unavailable=[db]

Describe the bug

• I'm using v1.2.0_beta1 and I'm getting the following error when starting the Validator node.

ERROR[11-17|07:47:40.973] Unavailable modules in HTTP API list unavailable=[db] available="[admin debug web3 eth txpool personal istanbul miner net]"

[FEATURE]メモリリーク、BlockGasLimit対応

現状の課題

• メモリリークの件
  (引き続き様子は見るが)パッチを充てる方針で。コミュニティには報告する。
  ethereum/go-ethereum@3ebfeb0
• BlockGasLimitの件
  v2.1とv2.7でデフォルト値が異なる。
  パラメタを変更する方向で。
  対象は一般、金融の両方。今後、リリースする方向で調整を進める。

[FEATURE] deprecated warning

Is your feature request related to a problem? Please describe.

• Version: v1.2.0_beta2
• The following warnings are detected.

WARN [11-18\|03:22:26.110] The flag --rpc is deprecated and will be removed in the future, please use --http
WARN [11-18\|03:22:26.110] The flag --rpcaddr is deprecated and will be removed in the future, please use --http.addr
WARN [11-18\|03:22:26.110] The flag --rpcport is deprecated and will be removed in the future, please use --http.port
WARN [11-18\|03:22:26.110] The flag --rpcapi is deprecated and will be removed in the future, please use --http.api
WARN [11-18\|03:22:26.111] The flag --rpcvhosts is deprecated and will be removed in the future, please use --http.vhosts
WARN [11-18\|03:22:26.112] Found deprecated node list file /eth/geth/static-nodes.json, please use the TOML config file instead.

Describe the solution you'd like

• Make the changes as indicated in the warning message.

[FEATURE] Non-degrade testing for network upgrades

1. Is your feature request related to a problem? Please describe.

• When upgrading ibet Network, we would like to add a test to guarantee that no degrading has occurred in the processing of smart contracts.

2. Describe the solution you'd like

For a simple contract, we will add a test that checks the following

• Deploy on the old version network.
• Deploy on the new version network.
• Verify the call and transaction of the old and new contract functions can be performed normally.

[BUG] Not graceful shutdown (local_network)

Describe the bug

• Currently, we have not implemented shutdown using SIGINT for local-network Quorum nodes. This is not a graceful state, as shown in the following link.
• https://ethereum.stackexchange.com/questions/10566/is-it-safe-to-kill-geth-with-sigterm

Additional context

• As well as ibet-fin, shutdown using SIGINT is also performed for nodes in local_network.

[FEATURE]動作保証環境の明記

現状の課題

Quorumの動作保証環境をReadmeに明記した方が良い

[FEATURE] Container version in hands-on documentation

Is your feature request related to a problem? Please describe.

• The container version is written in the hands-on document of each network, but it is inefficient to maintain because it needs to be updated at the same time when each version is upgraded.

Describe the solution you'd like

• We would like to change the description so that it does not need to be edited at every version upgrade.

[FEATURE]Change Network setting procedure

Is your feature request related to a problem? Please describe.

• Regular update of ibet network will be done in July 2021.

• We will change the procedure of network.

Describe the solution you'd like

• As above.

[FEATURE] Add new bridge general's enode to static-nodes.json

Is your feature request related to a problem? Please describe.
Add new bridge general's enode to Testnet's static-nodes.json.

Describe the solution you'd like
test-network/general/static-nodes-general.json

"enode://02b28f7ef6ca5f7ec0182eff8f1f7e741bf61628dc2e29b2318999903733eff1d542b6d96f77f7ca8bbf6de00f26c63991a94a7ba9326a52a509b52f71179f2f@13.115.14.133:30303?discport=0"

[FEATURE] Container base image and Go language upgrade

Is your feature request related to a problem? Please describe.

• Currently, we are using golang:1.13-alpine, but GoQuorum is using golang:1.15.5-alpine, which is an older version.

https://github.com/ConsenSys/quorum/blob/master/Dockerfile

Describe the solution you'd like

• We will upgrade to golang:1.15.5-alpine as well as GoQuorum v21.7.

[FEATURE]Quorumの設定値を記載する

現状の課題

設定すべきパラメタ等に関する記載がない

ソリューション案

パラメタの説明を記載する

代替案

上記の他に代替案がある場合は記載してください。

その他

その他の特記事項がある場合は記載してください。

[FEATURE] Network upgrade (July 2021)

We will be conducting a regular update of the ibet Network in July 2022.

Update details

• Update alpine image (v3.14.6 or later)

[FEATURE] Description of docker's volume mount path

Is your feature request related to a problem? Please describe.

• The current hands-on documentation explains how to git clone this repository and then start a docker container with each network directory as its mount path.
• For example:

$ docker pull ghcr.io/boostryjp/ibet-fin-network/general:v1.2.0
$ git clone https://github.com/BoostryJP/ibet-Network.git
$ cd ibet-Network/ibet-for-fin-network/general
$ cp ./static-nodes-general.json ./geth/static-nodes.json
$ docker run --name generalInit -e PRIVATE_CONFIG=ignore -v ./:/eth \
    ghcr.io/boostryjp/ibet-fin-network/general:v1.2.0 \
    geth --datadir /eth --nousb init /eth/genesis.json
$ docker run -d --name general -e PRIVATE_CONFIG=ignore -v ./:/eth \
    ghcr.io/boostryjp/ibet-fin-network/general:v1.2.0 run.sh 

• This is not a correct description and I think it should explain that any path can be used.

Describe the solution you'd like

• Modify the documentation to explain that any path can be mounted.

[FEATURE]Quorumバージョンアップ

現状の課題

Quorumをv2.1.0→v2.6.0にバージョンアップする。

[BUG] Quorum for localnet not shutting down gracefully

Describe the bug

The Quorum node for localnet is not shutting down gracefully.

The problem seems to be in the following places.
https://github.com/BoostryJP/ibet-Network/blob/develop/local-network/run.sh#L32

The correct search string is "geth --datadir".

[FEATURE]Review the contents of the Readme

Things to add to the Readme

• The guaranteed operating environment differs depending on whether it is an existing network or a new network, so the description should be deleted.
• Add an overview of how to participate in the network.
• Quorum version

[BUG]run.shの実行権限不足

バグの説明

run.shの実行権限が不足している。644

正しい挙動（想定）

755に修正する。

[FEATURE]Add setting of Bridge node to ibet-network

Is your feature request related to a problem? Please describe.

• Regular update of ibet network will be done in July 2021.
• We will add the Bridge node to ibet-network.

Describe the solution you'd like

• As above.

[FEATURE]Migrating Docker images to the GitHub Container Registry

Is your feature request related to a problem? Please describe.
Currently, we publish Docker images on BOOSTRY's ECR, but we would like to publish them directly from GitHub.

Describe the solution you'd like
I would like to store the built image in the GitHub Container Registry and publish it.

[FEATURE]ソフトウェアライセンスを追記する

現状の課題

ソフトウェアライセンスが記載されていない

ソリューション案

ライセンスを記載する

代替案

上記の他に代替案がある場合は記載してください。

その他

その他の特記事項がある場合は記載してください。

[FEATURE]テストネット、一般、金融毎にquorum、genesis.json、static-nodes.jsonを分けて保管する。

現状の課題

一般とテストネットが同じ物件になっていたりわかりにくい

ソリューション案

各ネットワーク毎に物件を整理する。

代替案

上記の他に代替案がある場合は記載してください。

その他

その他の特記事項がある場合は記載してください。

[FEATURE] Support Testing JSON-RPC `eth_getCode`

Is your feature request related to a problem? Please describe.

refs BoostryJP/ibet-Wallet-API#1097
refs BoostryJP/ibet-Prime#262

[FEATURE]ネットワークの概説を記載する

現状の課題

ibet、ibet for Finに関するネットワークの概要について説明がない

ソリューション案

概説を記載する

代替案

上記の他に代替案がある場合は記載してください。

その他

その他の特記事項がある場合は記載してください。

[FEATURE] Monitoring block synchronization

Is your feature request related to a problem? Please describe.

In general, block synchronization should be monitored in node operations.
We could add monitoring of block synchronization as a standard tool.

Describe the solution you'd like

• Add a monitoring script for block synchronization.
• Start the monitoring script with run.sh. When the synchronization stops, it will output an error message to the standard output.

[FEATURE] Add a general node for localnet

Is your feature request related to a problem? Please describe.

Currently, localnet is configured with only validator nodes, but we may want to use the General node in localnet.

We can use it by doing our own build, but we would like to maintain an official container image.

Describe the solution you'd like

Make the General node of localnet available by default.

[FEATURE] Add an explanation about Bridge nodes

Is your feature request related to a problem? Please describe.

We are often asked what a Bridge node is, or why we have Bridge nodes.
We would like to add an explanation to the document on this point.

Describe the solution you'd like

Add explanation about Bridge node.

[FEATURE] Quorum version up (July 2021)

Is your feature request related to a problem? Please describe.

• Regular update of ibet network will be done in July 2021.
• We will change the version of Quorum to v21.1 at this time.

Describe the solution you'd like

• As above.

[FEATURE] Add a description of the consensus algorithm

Is your feature request related to a problem? Please describe.

• I think the document should add a description of the consensus algorithm used by the network.

Describe the solution you'd like

• This should be added to the readme.

[FEATURE]Remove allow-insecure-unlock option from validator's startup shell

Is your feature request related to a problem? Please describe.

• Regular update of ibet network will be done in July 2021.
• We will remove allow-insecure-unlock option from validator's startup shell.

Describe the solution you'd like

• As above.

[BUG] E2E test container is failed python install

Describe the bug

• The pyenv installer uses aria2c, curl, or wget.
• But Those is not installed in the E2E test container, failed python install.

Downloading Python-3.8.7.tar.xz...
-> https://www.python.org/ftp/python/3.8.7/Python-3.8.7.tar.xz
error: failed to download Python-3.8.7.tar.xz

BUILD FAILED (Ubuntu 20.04 using python-build 2.2.2-1-gf2925393)

Results logged to /tmp/python-build.20211126065120.68.log

Last 10 log lines:
/tmp/python-build.20211126065120.68 /
error: please install `aria2c`, `curl`, or `wget` and try again

Additional context

• Install aria2c, curl, or wget in the container.