Giter Site home page Giter Site logo

Comments (3)

orbisvicis avatar orbisvicis commented on May 24, 2024

Apparently, "python2" isn't ubiquitous enough to warrant a patch. The above will remain in distro-specific package files.

from resynthesizer.

bootchk avatar bootchk commented on May 24, 2024

My understanding is that the hash bang is read by a shell. As I recall, the plug-in scripts are only usable from within GIMP and serve no purpose when called from a shell. Thus the hash bang is superfluous and I propose to remove it instead of changing it as you propose.

But I could be wrong, I need to study more especially concerning how GIMP in command line ( batch mode?) might execute plug-ins. In that case, I think GIMP must still be invoked first, GIMP invokes some version of a python interpreter, and GIMP does not read the hash bang.

Possibly the plug-in should check the version of Python separately, without the hash bang. I think it is of low priority, and would only serve rare users using very old Python.

Probably a higher priority for me to test that the plug-ins don't break under Python 3.

from resynthesizer.

orbisvicis avatar orbisvicis commented on May 24, 2024

I propose to remove it

+1, if batch mode doesn't require it. I'm not familiar with this.

plug-in should check the version of Python separately

-1

test that the plug-ins don't break under Python 3.

Here is an initial patch, as much as I could do without installing the plug-in and testing through gimp itself: http://sprunge.us/TjMR

There are some missing modules, such as "gettext", which I assume gimp will import in lieu of the plugin itself. Therefore I didn't fix these errors.

Also, testResynth.py seems broken:

(process:32019): GLib-CRITICAL **: g_hash_table_lookup: assertion `hash_table != NULL' failed
** (process:32019): ERROR **: could not find handler for message: 6
Trace/breakpoint trap

Causative line (119):

image = pdb.gimp_file_load(infilepath, infilepath, run_mode=RUN_NONINTERACTIVE)

from resynthesizer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.