Inconsistent application of color on Windows

[veleek]

Inconsistent application of color on Windows

[veleek]

FYI for those interested this issue: tartley/colorama#107 is the bug on colorama.

[veleek]

In digging into this a little bit more, I'm not sure that there's a bug here at all. It's just an odd behavior that caused unexpected results. The project that I'm working on has some code that attempt to import and initialize a ColoredFormatter after logging.basicConfig has been called. As a result, when colorama is initialized it wraps stderr but the handler that is generated by basicConfig is still referencing the un-wrapped stream.

PyCharm behaves mostly like a Unix terminal so it properly processes the escape codes. Unfortunately, colorama still detects it as Windows (when running on Windows) so it strips the escape codes and passes the windows console color codes (which PyCharm doesn't handle) so the result is no color at all.

I think that this probably qualifies as a bug on colorama. I.e. figure out how to detect whether the terminal actually supports escape codes instead of just 'is windows'. This will probably become more important since there's been some talk around getting Windows to support the color codes.