Highlights not working

[box]

Highlights not working

[Blackbaud-BrianSchalk]

Just upgraded to the latest version today 1.23? Also tried on code pen with the same results. On Dec 20, 2017, at 3:10 PM, Sumedha Pramod <[email protected]<mailto:[email protected]>> wrote: Hey Brian! What version of Preview are you using? I am not able to reproduce this on the latest version of Preview. Thanks! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#86 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALbnv_vpFqhqSbOiJmOoO_sk5tZCwCpgks5tCWmHgaJpZM4RI5GM>.

[pramodsum]

Hey Brian!
What version of Preview are you using? I am not able to reproduce this on the latest version of Preview.
Thanks!

[pramodsum]

Ah. Looks like we're missing some safety checks when checking if you're clicking on a draw annotation and you haven't added any drawings yet. I was able to see the error being thrown in the console (fixed by #87), but the error didn't prevent the creation of highlights. You mentioned it was blocking your highlights from being created?

Thanks for reporting it! I'll let you know as soon as this change makes it live.

[pramodsum]

Sorry, this accidentally got closed with my pull request. It should be fixed with Preview v1.23.1

[Blackbaud-BrianSchalk]

Thank you for your prompt attention to the issue, I upgraded to 1.23.1 and although I no longer see the error in the console log, I still cannot highlight. Perhaps this is an issue with our implementation? Do you have a working example of highlighting that I can see? —Brian On Dec 20, 2017, at 6:06 PM, Sumedha Pramod <[email protected]<mailto:[email protected]>> wrote: Sorry, this accidentally got closed with my pull request. It should be fixed with https://github.com/box/box-content-preview/releases/tag/v1.23.1 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#86 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALbnvyhJWRqDOrmfctuhWb7S6FDHryERks5tCZLhgaJpZM4RI5GM>.

[pramodsum]

Hey @Blackbaud-BrianSchalk,
This codepen example should show you how to enable/disable all the different types including a working version of highlight annotations. Just swap in your access token and file id in the example.

https://codepen.io/box-platform/pen/4fd06b49a729719b48cb5ea1a0267bc0/

[Blackbaud-BrianSchalk]

Thanks, That is the same codepen I originally used to test the highlighting issue. If i plug in my access token and file id, I still cannot highlight. I have tried multiple browsers and multiple computers. Hard to tell from this screenshot but I am trying to select text and it is not highlighting. Could this be an issue with how our tokens are generated? [cid:[email protected]] —Brian On Dec 21, 2017, at 3:51 PM, Sumedha Pramod <[email protected]<mailto:[email protected]>> wrote: Hey @Blackbaud-BrianSchalk<https://github.com/blackbaud-brianschalk>, This codepen example should show you how to enable/disable all the different types including a working version of highlight annotations. Just swap in your access token and file id in the example. https://codepen.io/box-platform/pen/4fd06b49a729719b48cb5ea1a0267bc0/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#86 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALbnv3c9Rpj4tSKwPb1WWmNl_3yNbWAJks5tCsTEgaJpZM4RI5GM>.

[pramodsum]

Do you have download permissions on your file? If that's the case, the text layer on the document is not accessible so highlighting is disabled.

If you see the token scopes (https://developer.box.com/docs/annotations#section-access-token), you need the item_download scope in order to select/highlight text.

[Blackbaud-BrianSchalk]

Thank you. I added download permission and can now highlight. —Brian On Dec 21, 2017, at 4:35 PM, Sumedha Pramod <[email protected]<mailto:[email protected]>> wrote: Do you have download permissions on your file? If that's the case, the text layer on the document is not accessible so highlighting is disabled. If you see the token scopes (https://developer.box.com/docs/annotations#section-access-token), you need the item_download scope in order to select/highlight text. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#86 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALbnv9vqTwLm8at9VnyjhKKxINcoywNnks5tCs8LgaJpZM4RI5GM>.