box/box-annotations

JavaScript library for annotations on files rendered with Box Content Preview

box-annotations's Issues

unable to pick css from import 'box-ui-elements/dist/picker.css';

Hi i am using box ui element to open content picker for folder , but it seems the css is not getting pulled from the nodemodules and thus the i am not getting the desired view

`import React from 'react';
import { ContentPicker } from 'box-ui-elements';
import messages from 'box-ui-elements/i18n/en-US';

import 'box-ui-elements/dist/picker.css';
import App from "./App";

const FolderSelectionView = ({ }) => (

    <ContentPicker
        token='Bz665dgmKkStuTzJpBdZJSfpxPL2RSSK'
        language='en-us'
        type='folder'
        maxSelectable={1}
        messages={messages}
    />

);

export default FolderSelectionView;`

Box crashes when trying to hide preview while file is loading

Environment:

• Preview version: 2.9.0

Desktop:

• OS: Windows 10
• Browser: Chrome
• Version: 74.0.3729.157

Steps to reproduce the problem:

1. Open this codepen (everything is set up to reproduce)
2. Observer console (possibly need to rerun/refresh page few times cause issue is sporadic)
   This codepen is emulating behaviour when the user is trying to close preview immediately after he opened it. Reproducible when annotations are configured through viewers prop.
   What is the expected behavior? (Screenshots can be helpful here)
   Preview hides successfully without errors
   What went wrong? (Screenshots can be helpful here)
   
   Errors appear. Box preview crashes (continue trying to load). Some time later another error appears:
   
   Preview state:
   
   Link to application or sample code:
   codepen

Unable to post annotations from Safari on iOS

Please fill out the following template so we can reproduce and fix your issue as quickly as possible!

Environment:

• Preview or Annotations version: Content Preview version 1.28.1
• Browser name and version: Safari
• Operating system and version: iOS version 11.2.5

Steps to reproduce the problem:

1. Click on the annotate button in the top right
2. Click on the document to annotate

What is the expected behavior? (Screenshots can be helpful here)
The new annotation modal comes up with a cursor in the text box. When done typing, clicking on "Post" submits the annotation and dismisses the annotation modal.

What went wrong? (Screenshots can be helpful here)
The modal comes up to create an annotation, but there doesn't appear to be a cursor in the text box. However, when I start typing, the text appears in the text box as I would expect. Clicking on the "Post" button dismisses the OS keyboard and pins the modal to the bottom of the screen, but does not appear to post the annotation. Subsequent clicks of the "Post" button do nothing and the annotation never posts.

On Chrome on the same iOS version we are able to post annotations, but only after clicking on the "Post" button multiple times.

Can't close point annotation popover

Environment:

• Preview version: 2.9.0

Desktop:

• OS: Windows 10
• Browser: Chrome
• Version: 74.0.3729.157

Steps to reproduce the problem:

1. Open this codepen (everything is set up to reproduce)
2. Click on point annotation.
3. Try to close it by clicking outside or on annotation icon
   It happens only with such viewers configuration (only 'point' and 'draw' annotation types enabled). If I add 'highlight' or 'highlight-comment' type issue disappears.
   What is the expected behavior? (Screenshots can be helpful here)
   Annotation details popover closes
   What went wrong? (Screenshots can be helpful here)
   Annotation details popover can't be closed using click
   

Link to application or sample code:
codepen

Annotations CSS for modals affects non-annotations modals

Please fill out the following template so we can reproduce and fix your issue as quickly as possible!

Environment:

• Browser name and version: Chrome 63
• Operating system and version: OSX 10.12.6

Steps to reproduce the problem:

1. Open preview of a large file in CodePen and press print. Note the appearance of the print popup.
2. Open preview of a large file in WebApp (with annotations cookie flip on) and press print. Note the appearance of the print popup.
3. Popups should look the same, but do not.

What is the expected behavior? (Screenshots can be helpful here)
What CodePen looks like (without annotations CSS):

What went wrong? (Screenshots can be helpful here)
What WebApp looks like (with annotations modal CSS):

Annotation comment not shown on hover for highlights when annotations are read-only

Please fill out the following template so we can reproduce and fix your issue as quickly as possible!

Environment:

• Preview version: 1.19.1
• Browser name and version: Firefox 57.0.1, Safari 11.0.2, Chrome 63.0.3239.84
• Operating system and version: Mac OS X 10.13.2

Steps to reproduce the problem:

1. As a user that can annotate, highlight text and add a comment
2. As a user that cannot annotate, view the document

What is the expected behavior? (Screenshots can be helpful here)
The comment associated with the highlight would be visible when hovering over the highlighted text.

What went wrong? (Screenshots can be helpful here)
The user who cannot annotate, but can view annotations, needs to click on the highlight in order to see the associated comment.

The scopes that are being sent for read-only annotations are: base_preview and annotation_view_all

Highlights not working

Please fill out the following template so we can reproduce and fix your issue as quickly as possible!

Environment:

• Browser name and version: All
• Operating system and version: OSX

Steps to reproduce the problem:

1. Use Box Content Preview to load a pdf document
2. Enable Annotations
3. Try to highlight text.

What is the expected behavior? (Screenshots can be helpful here)
Text should highlight

What went wrong? (Screenshots can be helpful here)
Text did not highlight.

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

how to run test/index.html file ?

When I run test/index.html file, the box file content show correctly but there is no annotations or annotations control visible.

react-intl package upgrade

Describe the solution you'd like
The Moji Team wants to upgrade all react apps to version 6 so that the latest features can be utilized and we can improve the quality of translations. box-annotations is one of the applications that is still on version 2.

If you need more info please contact #moji.

scrolling by touchscreen is not working after draw annotation

Environment:

• Preview version: 2.65.0

Desktop (please complete the following information):

• OS: Windows 10
• Browser: Chrome
• Version: 89.0.4389.82

Smartphone (please complete the following information):

• Device: iPad
• OS: OS X
• Browser: Safari and Chrome
• Version:

Steps to reproduce the problem:
This was originally found on an iPad using annotation but can be reproduced on Chrome using the Developer Tools Device Toolbar (Ctrl + Shift + M) and selecting Laptop with touch. Note, do not use a mouse scroll wheel or a trackpad's 2 finger scrolling. You must use the mouse with button to simulate a touchscreen in the correct developer tools mode.

1. Upload a .pdf, preferably one with multiple pages, to box
2. Enable Chrome's developer tools
3. Turn on the device toolbar (Ctrl + Shift + M)
4. Change device to Laptop with touch
5. Preview the uploaded .pdf
6. Use the mouse to simulate touch and scroll up and down in the document >> works fine
7. Enable annotation mode
8. Use the mouse to scroll up and down >> still works
9. Select the draw icon
10. Draw something on the document, click Save and then Done
11. Use the mouse to scroll up and down >> now it doesn't work

What is the expected behavior? (Screenshots can be helpful here)
Expected behavior is for scrolling using touchscreen to continue working.

What went wrong? (Screenshots, console logs, or HAR files can be helpful here)
Scrolling using touchscreen stopped working after performing a Draw annotation.

Additional context
There were no errors displayed in the console. Here is a HAR of the annotate action:
box_annotate_touchscreen.zip

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.