Comments (10)
I can verify the report during dragging; if we clone elements with an ID we must change the ID or duplicates will occur:
In my tests there is one original element with a certain ID and three .djs-dragger
elements (with duplicate IDs).
from bpmn-js.
Hi, thanks for the quick fix and sorry I didn't provide enough detail. I tried updating to [email protected]
but I still get the same errors. I've attached the HTML (as TXT as GitHub doesn't allow HTML) that results in the error. The duplicate ID is marker-6cnzxp45vcldqdsc7bp8xadlw
. You can see it twice in the HTML. My code is as follows:
<div class="canvas"></div>
<div class="properties"></div>
this.modeler = new BpmnModeler({
container: $('.canvas').get(0)!,
keyboard: {
bindTo: document,
},
propertiesPanel: {
parent: $('.properties').get(0),
},
bpmnRenderer: {
defaultFillColor: 'var(--bs-body-bg)',
defaultStrokeColor: 'var(--bs-body-color)',
},
});
Let me know if that helps or you need more information?
from bpmn-js.
The duplicated markers come from the minimap. Seems like it copies the SVG and only strips the root defs
from bpmn-js.
@marstamm Could be related to #2173?
from bpmn-js.
@boris-petrov Please share additional details on your setup:
- How do you embed bpmn-js
- How do you validate the HTML to find these issues
- If possible provide us with an export of the HTML for inspection
from bpmn-js.
Yes, this is related to the latest changes. We have 2 issues here:
- For preview, the comple SVG is copied, including the marker with the ID. We only add a cloned marker, but do not remove the copied one. This issue is new. This needs to be fixed in preview support.
- For drag-preview, we add the sequence flow multiple times. We add a connection from start shape, end shape and the connection itself. This is reproduceable on earlier version as well. Needs to be fixed in Move Preview.
from bpmn-js.
Closed via #2181.
from bpmn-js.
Correction, we simply clone everything in the djs-visual
when we replicate the elements in the minimap: https://github.com/bpmn-io/diagram-js-minimap/blob/156bcaa2d64013a13f4c601c013bb466ab124eed/lib/Minimap.js#L741-L746
we need to strip or change the markers there. Will look into this tomorrow
from bpmn-js.
Given the issues we are facing in multiple sections of our code, I'll also evaluate if there are other solutions than rendering as part of djs-visual
container
from bpmn-js.
Discussed with @nikku today:
- The minimap blindly copying elements, even those with IDs, is a bug. We will fix this in the minimap repo
- A potential other solution for tyleable markers (camunda/camunda-modeler#4307) would be to use
context-stroke
andcontext-fill
on the markers. The browser support for these is not well-documented, we will follow-up on this
from bpmn-js.
Related Issues (20)
- Select target instead of connection when connecting HOT 3
- Searching for Plane element results in error HOT 4
- elements.changed event is not triggering in custom rule HOT 7
- Append preview not cleaned up when deleting element through keyboard HOT 1
- Add typing for essential services and events
- Popup Menu positioning breaks inside "containing blocks" HOT 8
- make the artifacts element support flowElements HOT 1
- Remove button is not displayed for external labels HOT 1
- 'create' opinion cannot removed in palette entries HOT 1
- Call activity outline not customized
- Investigate if we want to use `context-fill` and `context-stroke` for rendering markers HOT 2
- Attached XML can't able to open by BPMN 2.0 HOT 7
- Attached XML can't able to open by BPMN HOT 2
- View camunda diagram XML in REACT HOT 1
- Diagram search should only commit navigation changes on `ENTER` HOT 1
- Type `moddle` parts of the library
- Connection label overlapping connection HOT 6
- Bug: demo + modeler example: if editing text followed by saveXML, the new text is missing in the xml HOT 6
- For the appendPreview service task, the icon is different from the real situation when it comes out.Also, the template custom icon cannot be previewed appendPreview HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bpmn-js.