Giter Site home page Giter Site logo

Comments (6)

philippfromme avatar philippfromme commented on August 24, 2024

Did you actually confirm the label editing though Enter or clicking outside of the element? If you don't do that before downloading the XML the label will be missing.

from bpmn-js.

philippfromme avatar philippfromme commented on August 24, 2024

A screencast demonstrating your issue would be helpful.

from bpmn-js.

c-antin avatar c-antin commented on August 24, 2024

Did you actually confirm the label editing though Enter or clicking outside of the element? If you don't do that before downloading the XML the label will be missing.

I was of the impression that editing text without clicking outside would be enough to register the change.
I guess it's more of an inconvenience than a bug, then?

from bpmn-js.

barmac avatar barmac commented on August 24, 2024

I can reproduce the issue. However, I don't think it's likely that we look into this. If you want to solve it on your own, you can call modeler.get('directEditing').complete() before modeler.saveXML() is executed.

from bpmn-js.

c-antin avatar c-antin commented on August 24, 2024

Thanks for pointing me to directEditing! Since saveXML is async, I save on 'commandStack.changed'. So sadly calling complete() does not help here!
Do you think it's a good idea to listen for keyup and calling complete() then?

edit: I tested it real quick: it's not a good idea, because it removes text focus...

from bpmn-js.

barmac avatar barmac commented on August 24, 2024

Have you tried to complete the direct editing when saveXML.start event is fired. This way you complete only once, and right before the XML serialization is performed.

For further questions regarding your project, please head to the bpmn.io forum.

from bpmn-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.