bradtreloar/alkaline-base

Base theme for Drupal

alkaline-base's Issues

Create styling for "large" button in button library.

Styles for enlarged buttons should be handled by button library, not banner.

(Will also need to add option for "large" class in bradtreloar/button_link)

Remove field_emphasis from paragraphs

field_emphasis was going to be a means to make a paragraph bigger, brighter etc but instead I decided not to give this functionality to content editors.

Use caption as alt for picture paragraph

button paragraph type

update gulpfile to v4 syntax

Remove color rules from backdrop component stylesheet

Use viewport units to handle height of responsiveMenu

Rather than relying on JS to calculate the height of the off-canvas element, just use calc(100vh - #{$top-bar-height})

Configure maximum image size for field_background_image

field_background_image should have a max size of 1920px and 1MB, and larger images should be automatically scaled down if they are too wide.

Change the grid layout of the footer region based on the number of blocks in it

Remove namespaced image styles

The following image styles need to be removed:

• alkaline_hero_small
• alkaline_hero_medium
• alkaline_hero_large

view list items should not have list styling

Restyle admin tabs as fixed element

Prevent FOUC

The Foundation responsive-menu widget takes a moment to load.

Need to look into Foundation's strategy for preventing FOUC

Add optional thumbnail field to portfolio project

Add option for wide grid

Allow grids to be "wide", as in not constrained to content width.

Change the alklaine icon function to use ` '#type' => 'html_tag'`.

Change the _alkaline_icon function to use '#type' => 'html_tag'.

function _alkaline_icon($name) {
  return [
    '#type' => 'html_tag',
    '#tag' => 'svg',
    'symbol' => [
      '#type' => 'html_tag',
      '#tag' => 'use',
      '#attributes' => [
        'xlink:href' => "#$name",
      ],
    ],
    '#attributes' => [
      'class' => 'icon',
    ],
  ];
}

Basic block needs more vertical margin

block--system-messages-block.html.twig should not extend block.html.twig

Add aside paragraph type

Collage image field has no figure wrapper

Without a figure wrapper, the img element is the direct descendant of the li element, which uses display: flex, stretching the image.

Add a preloader to hide FOUC, FOUT

Contact block needs more vertical margin

Heading in title bar isn't allowed to grow

Remove heading styles from banner

Headings should remain consistent across the theme, and responsibility for altering h1 styles should lie with the page_title library.

Add basic theming for tables in the page footer

derive theme_color from scss variable

Read theme/page.scss file to get $top-bar-background value.

Read _global.scss to get theme colors.

Allow node author to choose from several layouts for media objects.

The layout of the media_object paragraph type can only be changed by overriding the Twig template or by overriding the CSS. This means that a site can only have one media object style.

Fix this by adding view modes to media_object pciture fields that can be set on a per paragraph basis, rather than on a per content type basis.

For media_object, the picture field could have choices for large, small and banner.

The theme needs to work with or without these modes, for the sake of backwards compatibility.

page.js to track scroll position

Add responsive video paragraph type

Fix content alignment on 4xx pages

The template doesn't put the page content inside a content-width element

Change base theme to stable

I don't use the BEM class system employed by classy, so I should stop using it as a base theme.

Picture paragraph has class="image" not class="picture"

Remove super-regions from top bar

super-region was a bad idea--they make the header layout needlessly complex.

Write a useful and correct README

Basic block should not use article tag

Create lightbox modal

Create CSS and template for HTML mail

backdrop image not centred

No max width on article footer

Create carousel component

Use Foundation's orbit component.

body-section not set to 100% of width

Put more top padding on boilerplate

Media object spacing is too small in body section

the media-object paragraph only has a 1rem space between the figure and the text, which always looks too close.

Page title visibility not configured

should not be visible on node pages

allow theme color metatag value to be set in preprocessor

Remove row layout container

I experimented with using a "row" wrapper to provide padding and alignment for content but the block wrapper already does this job well enough.

don't display figcaption when caption is not set.

Fix cell width for 1 column grids

Table CSS not limited to content region

Add grid paragraph type

Add grid paragraph type to serve as a container for other paragraphs.

The grid size should be configured in a preprocess function so that the grid size can adapt to the number of children. This also allows a subtheme to override the breakpoints.

This should also make the cards and pictures fields redundant, since they are just specific use-cases of a grid container.