powercalc's entity_id should be generated from sensors' entity_id

[bramstroker]

powercalc's entity_id should be generated from sensors' entity_id

[bramstroker]

Thanks for reporting.
Could you try commenting lines (147, 148, 151 and 152) in sensor.py please in you installation and see if this helps?

https://github.com/bramstroker/homeassistant-powercalc/blob/master/custom_components/powercalc/sensor.py#L147

[pejotigrek]

Thanks for reporting.
Could you try commenting lines (147, 148, 151 and 152) in sensor.py please in you installation and see if this helps?

https://github.com/bramstroker/homeassistant-powercalc/blob/master/custom_components/powercalc/sensor.py#L147

tried that few minutes ago - no sensor created at all :( [strange?]

[bramstroker]

Ah ok that sucks. Will have to do some further testing / debugging to reproduce this issue and solve it.
Will be able to in a few days.

[pejotigrek]

no problem, I can test it further then if you'll want - just need information what to do :)

[pejotigrek]

ok, so first of all: I have no idea what I'm doing (being more like a copy-n-paste-programmer that barely understands python), and I don't know if it makes any sense, but I was staring at your code & comparing some powercalc created entities with those in my Home Assistant.

there are lines in sensor.py that call entity_entry.entity_id (like L298) - I guess that it's printing the "original" HomeAssistant sensor/light/etc. entity_id in the log for debugging purposes. and looking at lines 147-152 that you've mentioned, there's no sign of entity_entry.entity_id, just unique_id = entity_entry.unique_id (I understand that entity_entry is an object that stores all data about given entity).

I might be totally wrong, and yet don't want to blow up my working installation by messing up the code ;) but shouldn't that be something like unique_id = entity_entry.entity_id.replace("", source_entity_domain)? I'm sure my "code" is wrong but you know what I mean :) (also: if this unique_id is exactly that you can forget about my comment here ;))

[pejotigrek]

additional reports below

KODI instance on RaspberryPi3

• entity_id: media_player.1_living_kodi
• powercalc entities: sensor.none_energy, sensor.none_power
• I've checked in the integration dashboard - KODI model is listed as "unknown"

my Samsung TV:

• entity_id: media_player.1_living_tv
• power calc entities: sensor.ue50f6400_energy, sensor.ue50f6400_power
• I've checked in the integration dashboard - TV model is listed as "UE50F6400"

so it clearly takes the model name and builds entities based on this

[bramstroker]

Yes currently it takes name of the original entity to construct the power and energy sensor name. And from this name the entity_id is generated.
I did some changes in #116 to use entity_id as a base, but this is a major change and complex (I am not sure this has no side effects for other users), because when the entity_id changes they could loose historic data.
Will first do some extensive testing myself.

[pejotigrek]

I did some changes in #116 to use entity_id as a base, but this is a major change and complex (I am not sure this has no side effects for other users), because when the entity_id changes they could loose historic data.

understood, but I guess that entity_id is nothing you'll change too often [probably only few times at the start of the config] yet it is something that people are using to identify entities so IMHO it is more logical to use this than the original entity or even model name, which are somewhere deep inside dashboard.

Will first do some extensive testing myself.

sure, if I can help somehow with testing - feel free to ask! :)

[bramstroker]

Just did a lot of cleanups and refactoring and issued first beta. v0.5.0-beta.1.
Are you able to test with this version and let me know your findings?

[pejotigrek]

Just did a lot of cleanups and refactoring and issued first beta. v0.5.0-beta.1.
Are you able to test with this version and let me know your findings?

removed all powercalc sensors, installed v0.5.0-beta.1, re-added all entities and... so far, so good! looks like all powercalc entity_ids are created from corresponding homeassistant's entity_ids. above mentioned issues with computer, tv and kodi - are gone! 👍 other things seems to work like earlier 👍

[bramstroker]

Feature is released