Giter Site home page Giter Site logo

Comments (11)

bramstroker avatar bramstroker commented on August 14, 2024 2

@ThomDietrich I prefer to keep lowercase the default, but will add an option to configure the name format, so users can override it themself.

from homeassistant-powercalc.

ThomDietrich avatar ThomDietrich commented on August 14, 2024 1

@CM000n Thanks!

That's a good call. My experience tells me that most integrations capitalize their friendly names. I've just looked at my home setup and there is only one integration that has lowercase entity names (however it mixes in some uppercase names, so let's not look at this one for guidance 😉) I don't think there is a formal rule for this.

from homeassistant-powercalc.

bramstroker avatar bramstroker commented on August 14, 2024 1

Configurable entity name has been implemented

from homeassistant-powercalc.

bramstroker avatar bramstroker commented on August 14, 2024

Hi, good to hear. Yes changing that line should fix it.
You can create a PR if you want.

from homeassistant-powercalc.

CM000n avatar CM000n commented on August 14, 2024

I've noticed this kind of representation as well, but wasn't sure if a change makes sense. Not that it's just our German habit to capitalize proper names and nouns. 😉 But since @bramstroker probably sees it similarly, I have made a small PR to it

from homeassistant-powercalc.

bramstroker avatar bramstroker commented on August 14, 2024

I don't have a hard preference for one or the other. I think it's more a german thing to do it. I'm looking for formal rules, but not sure what to search for.
Power is a common noun in the English language and should not be capitalized as far as I'm concerned. Only when it is used in the beginning of the sentence.
In my case it would look ugly because I only write the first letter of my entity name capitalized (Spots keuken = Spots kitchen in English), which will become "Spots kitchen Power".

from homeassistant-powercalc.

ThomDietrich avatar ThomDietrich commented on August 14, 2024

Generally my decision would be in favor of how most prominent integrations do it. Looking at different other integrations, I am seeing a mix but also a couple of integrations which work with lowercase. I would be okay to accept that and discard the request here ;)

from homeassistant-powercalc.

ThomDietrich avatar ThomDietrich commented on August 14, 2024

Fixed in #77

Thanks!

from homeassistant-powercalc.

bramstroker avatar bramstroker commented on August 14, 2024

Fixed in #77

Thanks!

Yes it's almost ready. Need to do some final testing and update the readme

from homeassistant-powercalc.

bramstroker avatar bramstroker commented on August 14, 2024

Readme has been extended and this feature is merged into master.
Please let me know if this works for you @ThomDietrich

from homeassistant-powercalc.

ThomDietrich avatar ThomDietrich commented on August 14, 2024

Looks great

from homeassistant-powercalc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.