brandonfoong/ped

ped's Issues

Save to disk not implemented

The UG suggests that the program will save its contents to shortlist.txt.

However, during an execution, it seems like no new files are created.

Formatting bug in UG

The instructions for transferring data in the UG uses single quotations, rather than backticks to denote a file. Writing the filename as shortlist.txt may be clearer for the users.

This also occurs in other sections of the UG, for example, in the Quick Start section. Surrounding the command in backticks would make it clearer as a command to be run in the terminal.

Help command doesn't display the correct message

After executing the help command, the following output is shown:

This is different from the expected output in the UG, which shows a list of all commands. A screenshot of the UG at the point of the Demo PE is attached below.

Filter without arguments crashes the program

If filter is given as a command to the program without any arguments, it crashes the program immediately with the following error message:

Blank command string causes program to crash

When (single space character) is provided as the input to the program, it crashes with the following error message:

Formatting errors in UG

In the UG, :bulb: is used instead of the corresponding emoji, as shown below:

This also occurs in the instructions of the remove command.

save and shortlist commands not implemented

The UG suggests that one can use save and shortlist, however, during testing, these 2 commands were not interpreted as valid commands.

Filter command doesn't parse spaces correctly

In the UG, it is stated that strings with spaces can be used as the input for the parameter location.

However, when running the program, it seems like only the first word is taken, as shown below:

Bounds checking not performed in the filter command

In the UG, it is stated that if lease_remaining is the parameter to filter by, then the maximum value will be 99.

However, on testing, it seems like bounds checking is not performed, and it accepts values more than 99, negative values, and even strings.

Too many commands can lead to a stack overflow

By running any command many times (e.g. filter abc 123), we can get a stack overflow error, as shown below:

This could lead to issues when users run too many commands in a single instance of HDBuy.

Wrong executable name in UG

In the UG, the command to run the executable file is given as java -jar hdbuy.java, as shown below. However, the filename of the executable is hdbuy.jar.