brave-intl/bat-native-anonize

bat-native-anonize's Issues

iOS config fails when used to create a wallet in native-ledger

Generated this relic_conf.h based on Relic's own iOS preset however this configuration fails to create a wallet in native-ledger (citing ANONVK.read: failed)

Replacing the include iOS uses in BUILD.gn to the macOS relic_conf.h fixes this, however it should be checked to make sure that this is valid to do (or perhaps alter the iOS relic conf a different way)

Full Ledger Error Log

ERROR: Wallet creation didn't finish or corrupted. We need to clear persona Id and start again
RESPONSE: 
[ RESPONSE - requestCredentialsCallback ]
> time: 1556219871
> result: Success
> response: {"payload":{"adFree":{"currency":"BAT","fee":{"BAT":20},"choices":{"BAT":[20,30,50,85,100]},"range":{"BAT":[20,100]},"days":30}},"registrarVK":"==========ANONLOGIN_VK_BEG==========\n5Zo7fjdryszdwgAZO+HiK18yErXRoPvRkmYmo4E2UQV 4NMDAdwHg0z3LdGN3KkOoFLbza3SpeUWBcMKOUvJ8O1 1\n7MpAGVMgs+tuMQs4pH+nKUh0M+rl21RyUAdhRHKGhq4 5LXnl7uUw0XwaSTIojyDh4hODTEcT5BAiAhPCGIItDM 1\n2qtVvVwfxlDGzPSXXl0Ms94eycXiUJpthRp6uAjrjW8 Auhpv58KOuncZfXB1eekbOwTXloSAgPPRJ3A1g2a1MZ 1\n41nN9zSpWB6xfefhy/BWOouZnE5Vz+Akgtu3WavASEJ AF4pxNogZT38xdPdxe51RIGaFXKNVj3K2vbfN3uzI1T 1\n31ND6Q8qewDElWUU88rMWn4RZl95sjbSvoimlfsVFEg 8VjyRwkfd4dWwMQhShAIiyY0L9tOiJIR4PWlRIwyQs6 wLm/Ph3gh2ZtdqNbGJIcQM1LoCr+23zELEwUKvAnSL 1sWQdlB2UL0xSqgNcb9NObxiSof322GgHUg2nq43Y4l 1 0\n===========ANONLOGIN_VK_END=========="}
> headers Cache-Control: private
> headers Connection: keep-alive
> headers Content-Encoding: gzip
> headers Content-Type: application/json; charset=utf-8
> headers Date: Thu, 25 Apr 2019 19:17:51 GMT
> headers Server: Cowboy
> headers Transfer-Encoding: Identity
> headers Vary: accept-encoding
> headers Via: 1.1 vegur
> headers X-Rate-Limit-Limit: 60
> headers X-Rate-Limit-Remaining: 57
> headers X-Rate-Limit-Reset: 1556219910
[ END RESPONSE ]!!! input error on [5Zo7fjdryszdwgAZO+HiK18yErXRoPvRkmYmo4E2UQV 4NMDAdwHg0z3LdGN3KkOoFLbza3SpeUWBcMKOUvJ8O1 1]
ANONVK.read: failed

ERROR: Failed to initialize wallet

caller receives no indication if proof fails to allocate

bat-native-anonize/anon/anon.cpp

Line 479 in b8ef1a3

const char* proof = OnlineExtractableNIZK(c.alpha, c, ravk, p);

buffer is created

bat-native-anonize/anon/anon.cpp

Line 479 in b8ef1a3

const char* proof = OnlineExtractableNIZK(c.alpha, c, ravk, p);

before the null check for proof here

bat-native-anonize/anon/anon.cpp

Line 483 in b8ef1a3

if (proof) { memset((void*)proof, 0, strlen(proof)); free((void*)proof); proof=NULL; }

Set up branch protection

Branch protection is not enabled on this repo yet. Please do so; see https://github.com/brave/internal/wiki/Pull-request-security-audit-checklist for details

it would also be good to go through the rest of the security checklist for this repo

don't return memory that needs to be freed as a `const char *`

bat-native-anonize/anon/anon.cpp

Line 459 in b8ef1a3

return strdup(out.str().c_str());

This is a problem because we don't allow c-style casts like (void *) so we have to do a const cast to free it. We should just eliminate the call to c_str and return an std::string which has none of these issues